Skip to content

Commit 67bffe3

Browse files
committed
debuginfo: Fix gdbr-check expectations of formatting
This was a largely automated process, driven by the hack of a shell script below. The process to generate the patch was to repeatedly run the script until the changes reached a fixed-point. ```bash set -euo pipefail O=$(mktemp) ./x.py test src/test/debuginfo 2>&1 | tee $O || true awk ' function escape_pattern(pat, safe) { safe = pat gsub(/[][^$.*?+{}\\()|]/, "\\\\&", safe) return safe } BEGIN { p = 0; n = 0; } /---- \[debuginfo-gdb\]/ { if (p == 1) { printf("%s|%s|%s\n", src, error, expected); } src = $3; p = 1; n = 0; name = ""; } n == 1 && $0 ~ name { expected = $0; n = 0; } /error: line not found in debugger output/ { error = substr($0,43); split(error, pieces); name = escape_pattern(pieces[1]); print "Found " name " in: " $0 > "/dev/stderr" n = 1; } END { printf("%s|%s|%s\n", src, error, expected); } ' $O | while read l; do SRC="$(echo "$l" | cut -d'|' -f1 | sed 's/debuginfo-gdb/debuginfo/')" ERR="$(echo "$l" | cut -d'|' -f2)" V="$(echo "$ERR" | cut -d' ' -f1 | sed 's/\$/\\$/g')" EX="$(echo "$l" | cut -d'|' -f3)" if echo "$EX" | grep '^\$' > /dev/null; then echo $SRC sed -ri '/\/\/ gdbr-check:'"$V"' /s|(// gdbr-check:).*|\1'"$EX"'|' src/test/$SRC else # this is a bit questionable EX="$(echo "$l" | cut -d'|' -f2)" sed -ri '/\/\/ gdbr-check:'"$V"' /s|(// gdbr-check:).*|\1'"$EX"'|' src/test/$SRC echo $SRC: Failed to patch with: $l fi done echo $O ```
1 parent 0df87d9 commit 67bffe3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+233
-233
lines changed

src/test/debuginfo/associated-types.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
// gdb-command:print arg
1919
// gdbg-check:$1 = {b = -1, b1 = 0}
20-
// gdbr-check:$1 = associated_types::Struct<i32> {b: -1, b1: 0}
20+
// gdbr-check:$1 = Struct<i32> = {b = -1, b1 = 0}
2121
// gdb-command:continue
2222

2323
// gdb-command:print inferred
@@ -32,7 +32,7 @@
3232

3333
// gdb-command:print arg
3434
// gdbg-check:$5 = {__0 = 4, __1 = 5}
35-
// gdbr-check:$5 = (4, 5)
35+
// gdbr-check:$5 = {4, 5}
3636
// gdb-command:continue
3737

3838
// gdb-command:print a

src/test/debuginfo/borrowed-enum.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@
2020

2121
// gdb-command:print *the_a_ref
2222
// gdbg-check:$1 = {{RUST$ENUM$DISR = TheA, x = 0, y = 8970181431921507452}, {RUST$ENUM$DISR = TheA, [...]}}
23-
// gdbr-check:$1 = borrowed_enum::ABC::TheA{x: 0, y: 8970181431921507452}
23+
// gdbr-check:$1 = TheA = {x = 0, y = 8970181431921507452}
2424

2525
// gdb-command:print *the_b_ref
2626
// gdbg-check:$2 = {{RUST$ENUM$DISR = TheB, [...]}, {RUST$ENUM$DISR = TheB, __0 = 0, __1 = 286331153, __2 = 286331153}}
27-
// gdbr-check:$2 = borrowed_enum::ABC::TheB(0, 286331153, 286331153)
27+
// gdbr-check:$2 = TheB = {0, 286331153, 286331153}
2828

2929
// gdb-command:print *univariant_ref
3030
// gdbg-check:$3 = {{__0 = 4820353753753434}}
31-
// gdbr-check:$3 = borrowed_enum::Univariant::TheOnlyCase(4820353753753434)
31+
// gdbr-check:$3 = TheOnlyCase = {4820353753753434}
3232

3333

3434
// === LLDB TESTS ==================================================================================

src/test/debuginfo/borrowed-struct.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
// gdb-command:print *stack_val_ref
1919
// gdbg-check:$1 = {x = 10, y = 23.5}
20-
// gdbr-check:$1 = borrowed_struct::SomeStruct {x: 10, y: 23.5}
20+
// gdbr-check:$1 = SomeStruct = {x = 10, y = 23.5}
2121

2222
// gdb-command:print *stack_val_interior_ref_1
2323
// gdb-check:$2 = 10
@@ -27,11 +27,11 @@
2727

2828
// gdb-command:print *ref_to_unnamed
2929
// gdbg-check:$4 = {x = 11, y = 24.5}
30-
// gdbr-check:$4 = borrowed_struct::SomeStruct {x: 11, y: 24.5}
30+
// gdbr-check:$4 = SomeStruct = {x = 11, y = 24.5}
3131

3232
// gdb-command:print *unique_val_ref
3333
// gdbg-check:$5 = {x = 13, y = 26.5}
34-
// gdbr-check:$5 = borrowed_struct::SomeStruct {x: 13, y: 26.5}
34+
// gdbr-check:$5 = SomeStruct = {x = 13, y = 26.5}
3535

3636
// gdb-command:print *unique_val_interior_ref_1
3737
// gdb-check:$6 = 13

src/test/debuginfo/borrowed-tuple.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@
1818

1919
// gdb-command:print *stack_val_ref
2020
// gdbg-check:$1 = {__0 = -14, __1 = -19}
21-
// gdbr-check:$1 = (-14, -19)
21+
// gdbr-check:$1 = {-14, -19}
2222

2323
// gdb-command:print *ref_to_unnamed
2424
// gdbg-check:$2 = {__0 = -15, __1 = -20}
25-
// gdbr-check:$2 = (-15, -20)
25+
// gdbr-check:$2 = {-15, -20}
2626

2727
// gdb-command:print *unique_val_ref
2828
// gdbg-check:$3 = {__0 = -17, __1 = -22}
29-
// gdbr-check:$3 = (-17, -22)
29+
// gdbr-check:$3 = {-17, -22}
3030

3131

3232
// === LLDB TESTS ==================================================================================

src/test/debuginfo/box.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// gdb-check:$1 = 1
2121
// gdb-command:print *b
2222
// gdbg-check:$2 = {__0 = 2, __1 = 3.5}
23-
// gdbr-check:$2 = (2, 3.5)
23+
// gdbr-check:$2 = {2, 3.5}
2424

2525

2626
// === LLDB TESTS ==================================================================================

src/test/debuginfo/boxed-struct.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818

1919
// gdb-command:print *unique
2020
// gdbg-check:$1 = {x = 99, y = 999, z = 9999, w = 99999}
21-
// gdbr-check:$1 = boxed_struct::StructWithSomePadding {x: 99, y: 999, z: 9999, w: 99999}
21+
// gdbr-check:$1 = StructWithSomePadding = {x = 99, y = 999, z = 9999, w = 99999}
2222

2323
// gdb-command:print *unique_dtor
2424
// gdbg-check:$2 = {x = 77, y = 777, z = 7777, w = 77777}
25-
// gdbr-check:$2 = boxed_struct::StructWithDestructor {x: 77, y: 777, z: 7777, w: 77777}
25+
// gdbr-check:$2 = StructWithDestructor = {x = 77, y = 777, z = 7777, w = 77777}
2626

2727

2828
// === LLDB TESTS ==================================================================================

src/test/debuginfo/by-value-non-immediate-argument.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@
1919

2020
// gdb-command:print s
2121
// gdbg-check:$1 = {a = 1, b = 2.5}
22-
// gdbr-check:$1 = by_value_non_immediate_argument::Struct {a: 1, b: 2.5}
22+
// gdbr-check:$1 = Struct = {a = 1, b = 2.5}
2323
// gdb-command:continue
2424

2525
// gdb-command:print x
2626
// gdbg-check:$2 = {a = 3, b = 4.5}
27-
// gdbr-check:$2 = by_value_non_immediate_argument::Struct {a: 3, b: 4.5}
27+
// gdbr-check:$2 = Struct = {a = 3, b = 4.5}
2828
// gdb-command:print y
2929
// gdb-check:$3 = 5
3030
// gdb-command:print z
@@ -33,17 +33,17 @@
3333

3434
// gdb-command:print a
3535
// gdbg-check:$5 = {__0 = 7, __1 = 8, __2 = 9.5, __3 = 10.5}
36-
// gdbr-check:$5 = (7, 8, 9.5, 10.5)
36+
// gdbr-check:$5 = {7, 8, 9.5, 10.5}
3737
// gdb-command:continue
3838

3939
// gdb-command:print a
4040
// gdbg-check:$6 = {__0 = 11.5, __1 = 12.5, __2 = 13, __3 = 14}
41-
// gdbr-check:$6 = by_value_non_immediate_argument::Newtype (11.5, 12.5, 13, 14)
41+
// gdbr-check:$6 = Newtype = {11.5, 12.5, 13, 14}
4242
// gdb-command:continue
4343

4444
// gdb-command:print x
4545
// gdbg-check:$7 = {{RUST$ENUM$DISR = Case1, x = 0, y = 8970181431921507452}, {RUST$ENUM$DISR = Case1, [...]}}
46-
// gdbr-check:$7 = by_value_non_immediate_argument::Enum::Case1{x: 0, y: 8970181431921507452}
46+
// gdbr-check:$7 = Case1 = {x = 0, y = 8970181431921507452}
4747
// gdb-command:continue
4848

4949

src/test/debuginfo/by-value-self-argument-in-trait-impl.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@
2222

2323
// gdb-command:print self
2424
// gdbg-check:$2 = {x = 2222, y = 3333}
25-
// gdbr-check:$2 = by_value_self_argument_in_trait_impl::Struct {x: 2222, y: 3333}
25+
// gdbr-check:$2 = Struct = {x = 2222, y = 3333}
2626
// gdb-command:continue
2727

2828
// gdb-command:print self
2929
// gdbg-check:$3 = {__0 = 4444.5, __1 = 5555, __2 = 6666, __3 = 7777.5}
30-
// gdbr-check:$3 = (4444.5, 5555, 6666, 7777.5)
30+
// gdbr-check:$3 = {4444.5, 5555, 6666, 7777.5}
3131
// gdb-command:continue
3232

3333

src/test/debuginfo/c-style-enum-in-composite.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,31 +19,31 @@
1919

2020
// gdb-command:print tuple_interior_padding
2121
// gdbg-check:$1 = {__0 = 0, __1 = OneHundred}
22-
// gdbr-check:$1 = (0, c_style_enum_in_composite::AnEnum::OneHundred)
22+
// gdbr-check:$1 = {0, c_style_enum_in_composite::AnEnum::OneHundred}
2323

2424
// gdb-command:print tuple_padding_at_end
2525
// gdbg-check:$2 = {__0 = {__0 = 1, __1 = OneThousand}, __1 = 2}
26-
// gdbr-check:$2 = ((1, c_style_enum_in_composite::AnEnum::OneThousand), 2)
26+
// gdbr-check:$2 = {{1, c_style_enum_in_composite::AnEnum::OneThousand}, 2}
2727

2828
// gdb-command:print tuple_different_enums
2929
// gdbg-check:$3 = {__0 = OneThousand, __1 = MountainView, __2 = OneMillion, __3 = Vienna}
30-
// gdbr-check:$3 = (c_style_enum_in_composite::AnEnum::OneThousand, c_style_enum_in_composite::AnotherEnum::MountainView, c_style_enum_in_composite::AnEnum::OneMillion, c_style_enum_in_composite::AnotherEnum::Vienna)
30+
// gdbr-check:$3 = {c_style_enum_in_composite::AnEnum::OneThousand, c_style_enum_in_composite::AnotherEnum::MountainView, c_style_enum_in_composite::AnEnum::OneMillion, c_style_enum_in_composite::AnotherEnum::Vienna}
3131

3232
// gdb-command:print padded_struct
3333
// gdbg-check:$4 = {a = 3, b = OneMillion, c = 4, d = Toronto, e = 5}
34-
// gdbr-check:$4 = c_style_enum_in_composite::PaddedStruct {a: 3, b: c_style_enum_in_composite::AnEnum::OneMillion, c: 4, d: c_style_enum_in_composite::AnotherEnum::Toronto, e: 5}
34+
// gdbr-check:$4 = PaddedStruct = {a = 3, b = c_style_enum_in_composite::AnEnum::OneMillion, c = 4, d = c_style_enum_in_composite::AnotherEnum::Toronto, e = 5}
3535

3636
// gdb-command:print packed_struct
3737
// gdbg-check:$5 = {a = 6, b = OneHundred, c = 7, d = Vienna, e = 8}
38-
// gdbr-check:$5 = c_style_enum_in_composite::PackedStruct {a: 6, b: c_style_enum_in_composite::AnEnum::OneHundred, c: 7, d: c_style_enum_in_composite::AnotherEnum::Vienna, e: 8}
38+
// gdbr-check:$5 = PackedStruct = {a = 6, b = c_style_enum_in_composite::AnEnum::OneHundred, c = 7, d = c_style_enum_in_composite::AnotherEnum::Vienna, e = 8}
3939

4040
// gdb-command:print non_padded_struct
4141
// gdbg-check:$6 = {a = OneMillion, b = MountainView, c = OneThousand, d = Toronto}
42-
// gdbr-check:$6 = c_style_enum_in_composite::NonPaddedStruct {a: c_style_enum_in_composite::AnEnum::OneMillion, b: c_style_enum_in_composite::AnotherEnum::MountainView, c: c_style_enum_in_composite::AnEnum::OneThousand, d: c_style_enum_in_composite::AnotherEnum::Toronto}
42+
// gdbr-check:$6 = NonPaddedStruct = {a = c_style_enum_in_composite::AnEnum::OneMillion, b = c_style_enum_in_composite::AnotherEnum::MountainView, c = c_style_enum_in_composite::AnEnum::OneThousand, d = c_style_enum_in_composite::AnotherEnum::Toronto}
4343

4444
// gdb-command:print struct_with_drop
4545
// gdbg-check:$7 = {__0 = {a = OneHundred, b = Vienna}, __1 = 9}
46-
// gdbr-check:$7 = (c_style_enum_in_composite::StructWithDrop {a: c_style_enum_in_composite::AnEnum::OneHundred, b: c_style_enum_in_composite::AnotherEnum::Vienna}, 9)
46+
// gdbr-check:$7 = {StructWithDrop = {a = c_style_enum_in_composite::AnEnum::OneHundred, b = c_style_enum_in_composite::AnotherEnum::Vienna}, 9}
4747

4848
// === LLDB TESTS ==================================================================================
4949

src/test/debuginfo/cross-crate-spans.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ extern crate cross_crate_spans;
2626

2727
// gdb-command:print result
2828
// gdbg-check:$1 = {__0 = 17, __1 = 17}
29-
// gdbr-check:$1 = (17, 17)
29+
// gdbr-check:$1 = {17, 17}
3030
// gdb-command:print a_variable
3131
// gdb-check:$2 = 123456789
3232
// gdb-command:print another_variable
@@ -35,7 +35,7 @@ extern crate cross_crate_spans;
3535

3636
// gdb-command:print result
3737
// gdbg-check:$4 = {__0 = 1212, __1 = 1212}
38-
// gdbr-check:$4 = (1212, 1212)
38+
// gdbr-check:$4 = {1212, 1212}
3939
// gdb-command:print a_variable
4040
// gdb-check:$5 = 123456789
4141
// gdb-command:print another_variable

0 commit comments

Comments
 (0)