Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in CSS linter media query syntax #3356

Closed
tgr opened this issue Jul 19, 2017 · 0 comments · Fixed by #3357
Closed

Error in CSS linter media query syntax #3356

tgr opened this issue Jul 19, 2017 · 0 comments · Fixed by #3357

Comments

@tgr
Copy link
Contributor

tgr commented Jul 19, 2017

https://github.com/ajaxorg/ace/blob/v1.2.8/lib/ace/mode/css/csslint.js#L1737-L1771
The comment correctly defines a media query expression as '(' S* media_feature S* [ ':' S* expr ]? ')' S* but in the code the first S* is missing. E.g. @media all and ( max-width: 100px ) {} is a valid media query rule that gets erroneously rejected.
tgr added a commit to tgr/ace that referenced this issue Jul 19, 2017
@tgr
Fix missing whitespace in csslint media expression
f0044f7 
Fixes the grammar matching logic for 'expression' from CSS3 Media Queries to match the spec.

Fixes ajaxorg#3356.
@tgr tgr mentioned this issue Jul 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing whitespace in csslint media expression tgr/ace
1 participant
@tgr