Skip to content

Commit 55aa76a

Browse files
Code Modernization: Explicitly declare all properties in AtomParser.
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it's an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()` et al methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods build in. * For unknown _use of_ dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. In this case, the property added are explicitly referenced in this class, so fall in the "known property" category. Refs: * https://wiki.php.net/rfc/deprecate_dynamic_properties Props jrf. See #56034. git-svn-id: https://develop.svn.wordpress.org/trunk@59058 602fd350-edb4-49c9-b593-d223f7449a82
1 parent e6a8fdd commit 55aa76a

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/wp-includes/atomlib.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@ class AtomParser {
8686

8787
var $feed;
8888
var $current;
89+
var $map_attrs_func;
90+
var $map_xmlns_func;
91+
var $error;
92+
var $content;
8993

9094
/**
9195
* PHP5 constructor.

0 commit comments

Comments
 (0)