Nitpicks #603
Merged
Nitpicks #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto_compat.c spelling fix for:
2023-10-14 crypto_compat_free(): handle recent OpenSSL and LibreSSL
e5df014
Some mismatches between argument names in the declarations and
definitions:
tsnetwork.c, introduced in:
2008-04-25 Tarsnap 1.0.0
41f175d
crypto_compat.c, introduced in:
2017-03-13 crypto_compat: begin, add crypto_compat_RSA_valid_size()
d06e404
The header files uses `key`, as do all the other functions in this file.
Reported by: clang-tidy
gperciva
commented
Dec 19, 2023
| @@ -43,7 +43,7 @@ struct network_buf_cookie { | |||
| int flags; | |||
| }; | |||
|
|
|||
| static int callback_buf(void * cookie, int timedout); | |||
| static int callback_buf(void * cookie, int status); | |||
There was a problem hiding this comment.
This function is defined on line 57 (just a few lines down) with that arg being status, and that name seems a better match for how that arg is being used.
There was a problem hiding this comment.
Yeah, timedout is a historical name for that variable. I switched to status a long time ago but I guess I missed this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.