Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds propertybag set command #393

Closed
wants to merge 1 commit into from

Conversation

VelinGeorgiev
Copy link
Contributor

Adds propertybag set command
web EffectiveBasePermissions check added before adding new property in the property bag
Docs added

Solves #290

@coveralls
Copy link

coveralls commented Apr 1, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling bed3645 on VelinGeorgiev:propertybag-set into 0d82e4a on SharePoint:dev.

@waldekmastykarz
Copy link
Member

Awesome @VelinGeorgiev! I'll have a look shortly 👍

@waldekmastykarz waldekmastykarz self-assigned this Apr 2, 2018
@waldekmastykarz
Copy link
Member

According to the command help, I should be able to pass site- or server-relative URL of the folder where I want to set the property bag value. If I try the following setup:

spo propertybag set --webUrl https://contoso.sharepoint.com/sites/team-b --key myprop --value myval --folder '/sites/team-b/Shared Documents'

it fails with a File Not Found. error.

Using:

spo propertybag set --webUrl https://contoso.sharepoint.com/sites/team-b --key myprop --value myval --folder 'Shared Documents'

works just fine. So it seems that the command accepts a site-relative folder URL but not a server-relative one. Could you please double check @VelinGeorgiev?

@VelinGeorgiev
Copy link
Contributor Author

VelinGeorgiev commented Apr 2, 2018

Hey, @waldekmastykarz can we keep to site relative url and change the option description? The option says --folder and makes sense to be a folder within the site. The way I implemented it is exactly how PnP PowerShell works. Perhaps we can stay consistent and leave it to site relative folder path. What do you think?

Making it consider site or server relative folder path will add additional checks on our end to make it execute the correct XML request.

@waldekmastykarz
Copy link
Member

Makes perfect sense to keep it site-relative. Let's adjust the docs 👍

web EffectiveBasePermissions check added before adding new property

docs added

confirm var cleanup

propertybag folder desc update

propertybag folder desc update
@VelinGeorgiev
Copy link
Contributor Author

Server relative removed form the description.

@waldekmastykarz
Copy link
Member

Well done sir! 👏

@waldekmastykarz
Copy link
Member

Merged manually 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants