-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds propertybag set command #393
Conversation
Awesome @VelinGeorgiev! I'll have a look shortly 👍 |
According to the command help, I should be able to pass site- or server-relative URL of the folder where I want to set the property bag value. If I try the following setup: spo propertybag set --webUrl https://contoso.sharepoint.com/sites/team-b --key myprop --value myval --folder '/sites/team-b/Shared Documents' it fails with a Using: spo propertybag set --webUrl https://contoso.sharepoint.com/sites/team-b --key myprop --value myval --folder 'Shared Documents' works just fine. So it seems that the command accepts a site-relative folder URL but not a server-relative one. Could you please double check @VelinGeorgiev? |
Hey, @waldekmastykarz can we keep to site relative url and change the option description? The option says Making it consider site or server relative folder path will add additional checks on our end to make it execute the correct XML request. |
Makes perfect sense to keep it site-relative. Let's adjust the docs 👍 |
4e72660
to
9cd9cd1
Compare
web EffectiveBasePermissions check added before adding new property docs added confirm var cleanup propertybag folder desc update propertybag folder desc update
bed3645
to
03f4616
Compare
Server relative removed form the description. |
Well done sir! 👏 |
Merged manually 👍 |
Adds propertybag set command
web EffectiveBasePermissions check added before adding new property in the property bag
Docs added
Solves #290