Skip to content

Update blogs timestamp and details #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Update blogs timestamp and details #1829

merged 1 commit into from
Jul 29, 2024

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jul 29, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

image

The timestamp of blog made the order incorrect - updated as the release date (Jun 21) - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.22.0

As the release 4.23 of docker-selenium https://github.com/SeleniumHQ/docker-selenium/releases/tag/4.23.0-20240727 - adding one more person in list of contributor

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation, Enhancement


Description

  • Updated the date of the Selenium 4.22 release blog post to 2024-06-21 to reflect the correct release date.
  • Corrected a typo in the Selenium 4.22 release notes for the Java language section.
  • Added a new contributor to the Selenium 4.23 release notes.

Changes walkthrough 📝

Relevant files
Documentation
selenium-4-22-released.md
Update blog post date and fix typo in Selenium 4.22 release notes

website_and_docs/content/blog/2024/selenium-4-22-released.md

  • Updated the date of the blog post from 2024-05-16 to 2024-06-21.
  • Corrected a typo in the description of a Java feature.
  • +2/-2     
    selenium-4-23-released.md
    Add new contributor to Selenium 4.23 release notes             

    website_and_docs/content/blog/2024/selenium-4-23-released.md

  • Added a new contributor to the list in the Selenium 4.23 release
    notes.
  • +1/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Signed-off-by: Viet Nguyen Duc <[email protected]>
    Copy link

    netlify bot commented Jul 29, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 23a5900

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 29, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Maintain visual consistency in the contributors' section

    Ensure that the addition of new contributors using the gh-user shortcode includes
    proper alignment and formatting to maintain the visual consistency of the
    contributors' section. Consider adding necessary CSS or structural HTML adjustments
    if the new entry disrupts the layout.

    website_and_docs/content/blog/2024/selenium-4-23-released.md [90]

    +{{< gh-user "https://api.github.com/users/StegSchreck" >}}
     
    -
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion is valid as it ensures the visual consistency of the contributors' section, which is important for maintainability and user experience.

    8

    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you, @VietND96!

    @diemol diemol merged commit 17a68bd into SeleniumHQ:trunk Jul 29, 2024
    3 checks passed
    selenium-ci added a commit that referenced this pull request Jul 29, 2024
    Signed-off-by: Viet Nguyen Duc <[email protected]>
    
    [deploy site] 17a68bd
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants