-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update Custom Node Initialization in Grid Advanced Features #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Custom Node Initialization in Grid Advanced Features #1729
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Description updated to latest commit (36524f7)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you, @josh-pinwheelapi!
* Update Code Sample * Fix identation * Fix constructor * Fix typo * Fix identation --------- Co-authored-by: Diego Molina <[email protected]> [deploy site] 808af3e
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Description
With this change, the
Node
constructor now requires a thesessionTimeout
argument. Updating code sample to pass it along to theDecoratedLoggingNode
constructor.Motivation and Context
Current example will error out with the following error:
Types of changes
Checklist
PR Type
bug_fix, enhancement
Description
DecoratedLoggingNode
constructor across multiple language versions (English, Japanese, Portuguese-BR, Chinese) to include a newsessionTimeout
parameter.create
method in each language version to fetchsessionTimeout
fromNodeOptions
and pass it correctly to theDecoratedLoggingNode
constructor.Node
constructor requirements, preventing initialization errors.Changes walkthrough 📝
customize_node.en.md
Update Node Initialization to Include Session Timeout
website_and_docs/content/documentation/grid/advanced_features/customize_node.en.md
DecoratedLoggingNode
to includesessionTimeout
parameter.create
method to fetchsessionTimeout
fromNodeOptions
and pass it to the constructor.
customize_node.ja.md
Update Node Initialization to Include Session Timeout
website_and_docs/content/documentation/grid/advanced_features/customize_node.ja.md
DecoratedLoggingNode
to includesessionTimeout
parameter.create
method to fetchsessionTimeout
fromNodeOptions
and pass it to the constructor.
customize_node.pt-br.md
Update Node Initialization to Include Session Timeout
website_and_docs/content/documentation/grid/advanced_features/customize_node.pt-br.md
DecoratedLoggingNode
to includesessionTimeout
parameter.create
method to fetchsessionTimeout
fromNodeOptions
and pass it to the constructor.
customize_node.zh-cn.md
Update Node Initialization to Include Session Timeout
website_and_docs/content/documentation/grid/advanced_features/customize_node.zh-cn.md
DecoratedLoggingNode
to includesessionTimeout
parameter.create
method to fetchsessionTimeout
fromNodeOptions
and pass it to the constructor.