Skip to content

Docs for External Sessions Data store #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

krmahadevan
Copy link
Contributor

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Adding documentation to explain how to use an external data store for storing sessions.

Motivation and Context

The documentation for this is right now not there, even though the implementation already exists.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Nov 12, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit bd8f696
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/637270d541e2030008ad75b7
😎 Deploy Preview https://deploy-preview-1225--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krmahadevan krmahadevan force-pushed the docs_for_sessions_data_store branch from 30d1096 to 4fe067c Compare November 12, 2022 05:08
@krmahadevan
Copy link
Contributor Author

@diemol - Please let me know if there's anything that needs to be changed in this PR.

@krmahadevan krmahadevan force-pushed the docs_for_sessions_data_store branch from 4fe067c to e08c6c1 Compare November 14, 2022 02:40
@krmahadevan krmahadevan force-pushed the docs_for_sessions_data_store branch from e08c6c1 to bd8f696 Compare November 14, 2022 16:46
@krmahadevan
Copy link
Contributor Author

@diemol - I have addressed all your review comments, amended the commit with the changes and also rebased off of trunk. Please help take a look when you get the time.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @krmahadevan!

@diemol diemol merged commit 6094350 into SeleniumHQ:trunk Nov 15, 2022
selenium-ci added a commit that referenced this pull request Nov 15, 2022
@krmahadevan krmahadevan deleted the docs_for_sessions_data_store branch November 15, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants