Also define stdin or it will crash on Python + cx_Freeze: WindowsErro… #4503
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Python + cx_Freeze will result into an exception:
This is because there is no stdin defined in the service.py file for the
subprocess.Popen()
command. Underwater the subprocess tries to create a handle which also looks for stdin under Windows this gets a bit tricky when using Bash or cx_Freeze. So, I definedstdin
as well, and the crash is gone. Optionally you can also use:X
in the preceding checkbox, I verify that I have signed the Contributor License AgreementTrying to fix #536 & #547 as well.