-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Grid] Add delete files method #12501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grid] Add delete files method #12501
Conversation
method removes all files in the downloads directory Fixes SeleniumHQ#11986
If a file is downloaded and gets deleted from session, when the next downloaded file is present in session, it would give us only 1 file (last downloaded file) or all of them? |
it would give us only 1 file |
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12501 +/- ##
=======================================
Coverage 57.26% 57.26%
=======================================
Files 86 86
Lines 5335 5335
Branches 198 198
=======================================
Hits 3055 3055
Misses 2082 2082
Partials 198 198 ☔ View full report in Codecov by Sentry. |
@diemol - I have gone through the changes and they look good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @aldobrynin!
Thank you for reviewing, @krmahadevan!
Implement delete files method:
DELETE /session/{sessionId}/se/files
Fixes #11986
Description
Implemented method to delete all files in current session's downloads directory
Motivation and Context
Sometimes it is required to cleanup downloads directory. For example, in order to use pooled session developers need to be able to reset session state before next test run. Downloads directory is of the session features that one might want to cleanup during session lifecycle
Types of changes
Checklist