Skip to content

Adding ignore process match for IE Mode across bindings #12279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

diemol
Copy link
Member

@diemol diemol commented Jun 28, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Useful when IE Mode on Edge is launched from
and admin window. The caveat is that only
one Edge browser should be running on the
host.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Useful when IE Mode on Edge is launched from
and admin window. The caveat is that only
one Edge browser should be running on the
host.
@diemol diemol changed the title Adding ignore process match for IE Mode Adding ignore process match for IE Mode across bindings Jun 28, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 41.66% and project coverage change: +0.01 🎉

Comparison is base (2532076) 57.23% compared to head (4c30f10) 57.25%.

❗ Current head 4c30f10 differs from pull request most recent head 6aa701c. Consider uploading reports for the commit 6aa701c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12279      +/-   ##
==========================================
+ Coverage   57.23%   57.25%   +0.01%     
==========================================
  Files          86       86              
  Lines        5481     5488       +7     
  Branches      226      228       +2     
==========================================
+ Hits         3137     3142       +5     
  Misses       2118     2118              
- Partials      226      228       +2     
Impacted Files Coverage Δ
py/selenium/webdriver/common/selenium_manager.py 63.49% <16.66%> (+0.58%) ⬆️
py/selenium/webdriver/ie/options.py 64.13% <66.66%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 1976dbe into trunk Jun 28, 2023
@diemol diemol deleted the ignore-process-match branch June 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants