-
Notifications
You must be signed in to change notification settings - Fork 474
Add safe scaling xLASSQ routines from https://doi.org/10.1145/3061665 #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safe scaling xLASSQ routines from https://doi.org/10.1145/3061665 #494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 83.36% 83.41% +0.04%
==========================================
Files 1820 1821 +1
Lines 185545 185725 +180
==========================================
+ Hits 154673 154914 +241
+ Misses 30872 30811 -61
Continue to review full report at Codecov.
|
I have just added Doxygen preambles to all new files. The |
… Let the compiler determine the Fortran layout by the file extension
…la_xisnan extension
a017400
to
a4e4a7e
Compare
a4e4a7e
to
3606023
Compare
Update Doxygen headers Fix typos
…SQ-from-Edward-Anderson Add safe scaling xLASSQ routines from https://doi.org/10.1145/3061665
Edward Anderson stated in his paper https://doi.org/10.1145/3061665 the following:
The square root of a sum of squares is well known to be prone to overflow and underflow. Ad hoc scaling
of intermediate results, as has been done in numerical software such as the BLAS and LAPACK, mostly
avoids the problem, but it can still occur at extreme values in the range of representable numbers. More
careful scaling, as has been implemented in recent versions of the standard algorithms, may come at the
expense of performance or clarity. This work reimplements the vector 2-norm and the generation of Givens
rotations from the Level 1 BLAS to improve their performance and design. In addition, support for negative
increments is extended to the Level 1 BLAS operations on a single vector, and a comprehensive test suite
for all the Level 1 BLAS is included.
This PR replaces the original xLASSQ with Edward's safe scaling xLASSQ codes.
Since the codes were written in the Fortran90 standard, I removed
from the
CMakeLists.txt
. The compiler now determines the Fortran layout by the file extension.