Clear flags of SearchResult #4823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonre24
approved these changes
Jun 30, 2024
GuyAv46
approved these changes
Jun 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4823 +/- ##
==========================================
- Coverage 86.06% 86.06% -0.01%
==========================================
Files 190 190
Lines 33876 33877 +1
==========================================
- Hits 29157 29156 -1
- Misses 4719 4721 +2 ☔ View full report in Codecov by Sentry. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-4823-to-2.8 origin/2.8
cd .worktree/backport-4823-to-2.8
git switch --create backport-4823-to-2.8
git cherry-pick -x acc96a0e6360886bf819344fa002c3eda6e3c88b |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
* fix * skip on coordinator (cherry picked from commit acc96a0)
|
Successfully created backport PR for |
meiravgri
added a commit
that referenced
this pull request
Jun 30, 2024
* fix * skip on coordinator (cherry picked from commit acc96a0)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
Clear flags of SearchResult (#4823) * fix * skip on coordinator (cherry picked from commit acc96a0) Co-authored-by: meiravgri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some pipelines, we can re-use the search result by clearing it before populating it with a new result.
If not cleared appropriately, it might affect subsequent results.
This change ensures the flag indicating expiration is cleared and the search result struct is ready to be re-used.