Skip to content

[WIP] Rework Scheduler #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2017
Merged

Conversation

mbonneau
Copy link
Member

This PR returns the EventLoopScheduler to the v1 style construction.

This also adds AsyncSchedulerInterface for operators and observables that require async schedulers.

The README.md still needs to be updated.

@coveralls
Copy link

coveralls commented Feb 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5f5b4f9 on mbonneau:2.x-remove-interop into 7c058d5 on ReactiveX:2.x.

@martinsik
Copy link
Contributor

I'm just curious what happened to Loop and async-interop. I read the discussions in async-interop/event-loop repo and it seems the API is likely to change and it'll take some for the first stable release. Is this the reason we're going back to React\EventLoop?

@mbonneau
Copy link
Member Author

mbonneau commented Mar 3, 2017

@martinsik This change is being made because version 2 of RxPHP is taking too long to release with the dependency on the interop loop as the only blocking issue.

When first developing version 2 of RxPHP, it appeared that work on the Async-Interop Loop library had settled a bit and we had hoped that a stable version was close (see: async-interop/event-loop#119). We chose to try and push things forward with adoption of the interop loop standard. Since then, there have been more issues raised with the interop loop and consensus is taking a bit longer than we would like for inclusion into this next release of RxPHP.

Inclusion of the interop loop would have allowed users to remove a small bit of boiler plate code. With this PR, construction of the actual scheduler will be the same as it was in v1 and then you can set the default scheduler in the Scheduler static. RxPHP is loop agnostic (react is a dev-dependency for testing).

@mbonneau mbonneau added this to the 2.0 milestone Mar 3, 2017
@coveralls
Copy link

coveralls commented Mar 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 48fefb5 on mbonneau:2.x-remove-interop into 7c058d5 on ReactiveX:2.x.

@davidwdan
Copy link
Member

I'm going to merge this because the async interop loop project is all but dead. If and when there is a loop standard we can introduce new interop loop scheduler under 2.x and then bump the version to v3 or what ever the next major is, when we're reading to make it the default.

@davidwdan davidwdan merged commit 6c0e138 into ReactiveX:2.x Mar 13, 2017
@mbonneau mbonneau deleted the 2.x-remove-interop branch June 12, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants