Added -- for ros-args to find #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if anyone else had this issue, but although the docs states:
I don't think the double dash of "--gtest_output=xml:${result_file}" counts. In my ros2_control fork using generate_parameter_library I get the following error without the trailing "--":
<<< failure message
-- run_test.py: invoking following command in '/home/wrock/colcon_ws/build/joint_limits':
terminate called after throwing an instance of 'rclcpp::exceptions::UnknownROSArgsError'
what(): found unknown ROS arguments: '--gtest_output=xml:/home/wrock/colcon_ws/build/joint_limits/test_results/joint_limits/joint_limits_rosparam_test.gtest.xml'
-- run_test.py: return code -6
-- run_test.py: generate result file '/home/wrock/colcon_ws/build/joint_limits/test_results/joint_limits/joint_limits_rosparam_test.gtest.xml' with failed test
-- run_test.py: verify result file '/home/wrock/colcon_ws/build/joint_limits/test_results/joint_limits/joint_limits_rosparam_test.gtest.xml'
With this change, the tests run successfully