Fix deadlock in update_dynamic_parameters #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a deadlock condition in update_dynamic_parameters. The reason for the deadlock is that when it was declaring new parameters, the mutex was locked and the update callback would be called that would also try to lock the mutex.
To fix this, I updated all the usage of the internal state
params_to only be accessed through the getter method and a new private setter method. This means that the methods inside ParamListener only lock the mutex to copy or write to this internal state value instead of locking for the full duration of some of the methods that can cause callbacks to fire that might also need to lock the mutex.