Skip to content

Support nested mapped parameters #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 8, 2024
Merged

Support nested mapped parameters #166

merged 8 commits into from
Mar 8, 2024

Conversation

pac48
Copy link
Contributor

@pac48 pac48 commented Jan 1, 2024 •
edited
Loading

This issue #151 describes a problem when using multiple levels of nested maps. Currently, only one level of nesting is supported.

@pac48 pac48 changed the title upport nested mapped parameters Support nested mapped parameters Jan 1, 2024
@pac48 pac48 requested a review from Abishalini February 24, 2024 18:01
@pac48 pac48 requested a review from christophfroehlich March 5, 2024 03:38
christophfroehlich
christophfroehlich approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to review the jinja temlates, but the code generated from the provided yaml looks good.
And I tested it with ros2_controllers, it doesn't break current configs.

Should one update the README describing this?

@TomCC7 TomCC7 mentioned this pull request Mar 6, 2024
Draft
@pac48 pac48 force-pushed the pr-support-nested-mapped-parameters branch from 895887d to 7f7c2e5 Compare March 8, 2024 15:22
@pac48 pac48 force-pushed the pr-support-nested-mapped-parameters branch from 7f7c2e5 to b6633be Compare March 8, 2024 15:23
christophfroehlich
christophfroehlich approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sea-bass sea-bass merged commit 032a74d into PickNikRobotics:main Mar 8, 2024
sea-bass added a commit that referenced this pull request Mar 8, 2024
@sea-bass
Add info on #166
3012a5d
This was referenced Mar 18, 2024
Closed
Open
@pac48 pac48 mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@Abishalini Abishalini Awaiting requested review from Abishalini

+1 more reviewer

@sea-bass sea-bass sea-bass approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pac48 @christophfroehlich @sea-bass