Skip to content

Remove my_parameter from python template #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

Remove my_parameter from python template #146

merged 1 commit into from
Sep 11, 2023

Conversation

jaagut
Copy link
Contributor

@jaagut jaagut commented Sep 11, 2023

I have tested your great library for generating parameters for my Python node and noticed that the parameter my_parameter was always included. I presume this was accidental.

This PR removes the my_parameter from the parameter_library_header template.

pac48
pac48 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@pac48 pac48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. You are correct that the addition of that parameter is a mistake.

@tylerjw tylerjw merged commit f884398 into PickNikRobotics:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@tylerjw tylerjw tylerjw approved these changes

@pac48 pac48 pac48 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaagut @tylerjw @pac48