Make DynaLoader on MacOS check library existence with dlopen #18407
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20c37ec to
671e72e
Compare
96bcb5c to
671e72e
Compare
|
Thanks! The test passes here: |
671e72e to
e9cfe2d
Compare
|
But Maybe this failure should be reported in a separate issue? |
e9cfe2d to
728ef41
Compare
Yes, you probably should. Edit. On second thought, I think the problem there is obvious, and I don't know why nothing else failed on it. I'll push a fix on this branch. |
b695efe to
4ba2f8a
Compare
|
@hakonhagland could you please build and install this branch, and then install |
@Leont Yes, I tried to add |
That does say that much I'm afraid. Does |
|
No |
4ba2f8a to
5af2902
Compare
|
And now? |
|
It works now: |
|
@Leont See also Can't install XML::Parser on M1 Mac with homebrew perl 5.32. Do you know which commit fixed the issue with adding explicit linker flags in Big Sur for MakeMaker? |
5af2902 to
847a51c
Compare
847a51c to
161d656
Compare
161d656 to
36276df
Compare
A number of system libraries no longer exist as actual files, even though dlopen will pretend they do, so now we fall back to dlopen if a library file can not be found.
36276df to
d7db49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of system libraries no longer exist as actual files on Big Sur, even though dlopen will pretend they do, so now we fall back to dlopen if a library file can not be found.
CI suggests this works on Big Sur but this probably needs human confirmation that it will fix the issue from someone who actually runs Big Sur before being merged.