Clean up #493
Clean up #493
Conversation
|
@mastertinner, one note: |
|
@samvloeberghs, thanks for your feedback! I think that's a personal choice. I personally prefer no trailing commas for better legibility but I'm also fine with having them everywhere. What's crucial to me is that we are consistent about this and enforce it using the tslint rule. |
|
The community should decide here.. It's not really about personal choice, more about best practise + they are valid ES5, 6, ... More info here: |
|
No trailing commas please. Let's not make things ugly. I mean where we'd end up going this route.. |
|
@alvipeo please provide more arguments than it being ugly please, because that's personal feeling ;) |
|
Sure it's personal. As I said code looks ugly. |
|
What actually would be cool is there'd be some kind of wizard app asking questions on what would you like to include in the repo and then create that repo accordingly. One of the question would be "Do you want to have an ugly trailing commas in your project?" :)) |
|
go ahead, there's yeoman for that |
| @@ -17,9 +17,9 @@ | |||
| [Services](https://gist.github.com/gdi2290/634101fec1671ee12b3e#_follow_@AngularClass_on_twitter), | |||
| [Tests](https://angular.io/docs/js/latest/api/test/), [E2E](https://angular.github.io/protractor/#/faq#what-s-the-difference-between-karma-and-protractor-when-do-i-use-which-)), [Karma](https://karma-runner.github.io/), [Protractor](https://angular.github.io/protractor/), [Jasmine](https://github.com/jasmine/jasmine), [Istanbul](https://github.com/gotwarlost/istanbul), [TypeScript](http://www.typescriptlang.org/), [Typings](https://github.com/typings/typings), [TsLint](http://palantir.github.io/tslint/), [Codelyzer](https://github.com/mgechev/codelyzer), [Hot Module Replacement](https://webpack.github.io/docs/hot-module-replacement-with-webpack.html), and [Webpack](http://webpack.github.io/) by [AngularClass](https://angularclass.com). | |||
|
|
|||
| > If you're looking for Angular 1.x please use [NG6-starter](https://github.com/angularclass/NG6-starter) | |||
| > If you're looking to learn about Webpack and ES6 Build Tools check out [ES6-build-tools](https://github.com/AngularClass/ES6-build-tools) | |||
| > If you're looking to learn TypeScript see [TypeStrong/learn-typescript](https://github.com/TypeStrong/learn-typescript) | |||
There was a problem hiding this comment.
the two spaces at the end is a markdown feature for <br>
There was a problem hiding this comment.
@gdi2290 my text editor (and I think many others' removes trailing whitespaces...) That's why I've added blank lines between the points. Does that remedy the problem?
There was a problem hiding this comment.
it doesn't but I'll fix it in another commit
|
@mastertinner can you rebase so I can merge? |
# Conflicts: # README.md
|
Done |
|
@mastertinner thanks! |
# Conflicts: # package.json # src/platform/browser/directives.ts
# Conflicts: # config/webpack.dev.js # config/webpack.test.js
|
@gdi2290, can you please merge or let me know what you would like me to change before merging? |
* remove nitrous config * update deps * downgrade rxjs (as required by angular beta.13 * remove unnecessary comment * use const instead of var * remove trailing commas * unify multiline comments * jsdoc style author tag * update deps * use clearer tslint structure * remove nitrous * use single quotes * add blank lines * own comment for tslint * update deps * add nitrous back * update deps * downgrade rxjs as required by angular beta.14 * remove engineStrict because it's deprecated https://docs.npmjs.com/files/package.json#enginestrict
It introduces a couple of improvements that I would do.
There are some shortcomings in the code- and commenting structure.
Improved code structure and unified comments.
@gdi2290, please give me your feedback about which changes you like and which you don't.