-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
DX: for duplicated test methods check methods without parameters #8508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX: for duplicated test methods check methods without parameters #8508
Conversation
@@ -151,11 +154,21 @@ public function testFoo() | |||
} | |||
|
|||
/** | |||
* @requires PHP 8.0 | |||
* @requires PHP >= 8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @requires PHP >= 8.0 | |
* @requires PHP 8.0 |
i do not want to change those annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Iimplicit over explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know your opinion on it from previous PR.
Same time, I do not want to apply this change for whole repository, and even more for subset of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you "do not enjoy the massive changes in @requires PHP
annotations".
I wonder if there is any other reason. Usually, there are no objections to massive changes if they are good, and making the constraint explicit over implicit is IMHO a good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with both of you - I think that explicit >=
has value, but if we want to apply such change, then let's do it in separate PR with the changes for whole repo + maybe some test/rule for ensuring explicit syntax is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want to apply this change
thanks
No description provided.