Skip to content

DX: for duplicated test methods check methods without parameters #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kubawerlos
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 16, 2025

Coverage Status

coverage: 94.842%. remained the same
when pulling 7c152fc on 6b7562617765726c6f73:fix_more_duplicates
into a1f9c9b on PHP-CS-Fixer:master.

@kubawerlos kubawerlos enabled auto-merge (squash) March 16, 2025 21:41
@@ -151,11 +154,21 @@ public function testFoo()
}

/**
* @requires PHP 8.0
* @requires PHP >= 8.0
Copy link
Member

@keradus keradus Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @requires PHP >= 8.0
* @requires PHP 8.0

i do not want to change those annotations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Iimplicit over explicit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know your opinion on it from previous PR.
Same time, I do not want to apply this change for whole repository, and even more for subset of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you "do not enjoy the massive changes in @requires PHP annotations".
I wonder if there is any other reason. Usually, there are no objections to massive changes if they are good, and making the constraint explicit over implicit is IMHO a good reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both of you - I think that explicit >= has value, but if we want to apply such change, then let's do it in separate PR with the changes for whole repo + maybe some test/rule for ensuring explicit syntax is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to apply this change

thanks

@kubawerlos kubawerlos merged commit bedfbb0 into PHP-CS-Fixer:master Mar 16, 2025
28 checks passed
@kubawerlos kubawerlos deleted the fix_more_duplicates branch March 16, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants