Skip to content

tns install <module> command should do npm install "nativescript-dev-<module>" #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2015

Conversation

tailsu
Copy link
Contributor

@tailsu tailsu commented Oct 28, 2015

with --save-dev

  • dedicated grunt watch for compilation
  • execute 'prepare' hook

@tailsu
Copy link
Contributor Author

tailsu commented Oct 28, 2015

Related issue: #1117

…v-<module>" --save-dev

* dedicated grunt watch for compilation
* execute 'prepare' hook
process.env['TNS_HOOKS_DIR'] = path.join(projectDir, 'hooks');

if (!this.$fs.exists(moduleName).wait()) {
moduleName = 'nativescript-dev-' + moduleName;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add check for if module-name already has 'nativescript-dev'

@rosen-vladimirov
Copy link
Contributor

👍 for the code

@ns-bot
Copy link

ns-bot commented Oct 29, 2015

Test PASSed.

tailsu added a commit that referenced this pull request Oct 29, 2015
`tns install <module>` command should do npm install "nativescript-dev-<module>"
@tailsu tailsu merged commit a70b704 into master Oct 29, 2015
@tailsu tailsu deleted the sd/tsc branch October 29, 2015 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants