Skip to content

Implemented recaptcha v2 #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AmazingDreams
Copy link
Contributor

@AmazingDreams AmazingDreams commented Feb 19, 2018

Google will soon drop support for Recaptcha v1: #2641

I am using composer to install the google recaptcha lib.

Running in production here: https://pool.amazingsystems.nl/index.php

@daygle
Copy link
Contributor

daygle commented Feb 25, 2018

I think this change needs a little more work before merging.

I'll try make some time to make some improvements.

@TheSerapher
Copy link
Contributor

Let me know when this is ready and I wll trigger the merge :-) And re-target against development please, then I can merge right away.

@TheSerapher
Copy link
Contributor

Since composer isn't part of the installation procedure maybe add the library itself too? I doubt people would notice this is now required to run and I see people making tickets for this.

@AmazingDreams AmazingDreams changed the base branch from master to development March 7, 2018 11:29
@TheSerapher
Copy link
Contributor

The PR looks rather messed up. If you plan to submit recaptcha-v2 as a PR, please remove files that are unrelated to that change. Would make reverting more difficult, not to mention unrelated files makes a review pretty hard :-/

@AmazingDreams
Copy link
Contributor Author

Yes sorry. I suppose I messed up rebasing against dev..

@TheSerapher
Copy link
Contributor

No problem, let me know when it's ready for a review.

@AmazingDreams
Copy link
Contributor Author

I've just made a new merge request: #2692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants