Skip to content

Update findblock.php #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Update findblock.php #2605

merged 2 commits into from
Sep 29, 2017

Conversation

shtse8
Copy link
Contributor

@shtse8 shtse8 commented Sep 28, 2017

Fixed Invalid Blockhash by listsinceblock.

RPC call did not return 200: HTTP error: 500 - JSON Response: [-8] Invalid blockhash

Fixed Invalid Blockhash for listsinceblock.
Copy link
Contributor

@TheSerapher TheSerapher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with other coins too or would those throw an error then?

@TheSerapher
Copy link
Contributor

Again against development branch please. And maybe test out another few coins just to make sure they also work with this change and won’t throw an error.

@shtse8
Copy link
Contributor Author

shtse8 commented Sep 28, 2017

I am sure bitcoin family coins work on this getblockhash api. because it is a standard api to get the blockhash by index. If we worry it will throw an error, we can try catch and then set an empty string like previous version. Also, I have pointed to development branch already.

Try-Catch any exception thrown from `getblockhash` for safety.
@shtse8
Copy link
Contributor Author

shtse8 commented Sep 28, 2017

It should be fine now.
When it throw any exception returned by PRC, set it back to empty like previous version.

@TheSerapher
Copy link
Contributor

Thanks!

@TheSerapher TheSerapher merged commit cca0179 into MPOS:development Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants