Skip to content

Disable Sound in Dashboard #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2016
Merged

Disable Sound in Dashboard #2510

merged 3 commits into from
Jun 30, 2016

Conversation

iAmShorty
Copy link
Contributor

@iAmShorty iAmShorty commented Jun 30, 2016

  • Admin Settings to disable Button and Notification on Dashboard
  • Save Buttonstate even if you open another page and come back to Dashboard

1st Option - Completely disable Blocknotification Sounds

  • Go to Admin Panel -> System -> Settings -> Website
    -> change Disable Block Notification Sound to "Do not notify"

2nd Option - automatically active without changing settings

  • only click the button and the state will be saved, even if you reload the page or open another page and come back to dashboard. means, it's session wide and will keep the last toggled setting for block notification.

- Admin Settings to disable Button and Notification on Dashboard
- Save Buttonstate even if you open another page and come back to Dashboard
@TheSerapher
Copy link
Contributor

👋 @iAmShorty ! Nice to see this commit from you!

I'll do a quick look over and then merge to development. Other can test it there if they feel like it and if nothing comes back in a week or two we could merge into master.

@iAmShorty
Copy link
Contributor Author

iAmShorty commented Jun 30, 2016

wait a moment, found an issue with toggling the button state.

And btw, long time no see my friend. I hope You are fine...

@iAmShorty
Copy link
Contributor Author

done

@TheSerapher
Copy link
Contributor

Hmm looks like Composer dependencies broke: https://travis-ci.org/MPOS/php-mpos/jobs/141298784

Nothing major but maybe that could be fixed too? Not that we heavily rely on this to work ...

@iAmShorty
Copy link
Contributor Author

Composer dependencies?

Anything on my side i have to install or implement in my Development Environment?

@TheSerapher
Copy link
Contributor

Just the composer tool (see on their site) and running composer install should trigger this error. I am guessing a package has been removed from the Repo and it can't resolve the dependency anymore.

@TheSerapher TheSerapher merged commit 9e8caa5 into MPOS:development Jun 30, 2016
@TheSerapher
Copy link
Contributor

and POW! :D 👍

@iAmShorty
Copy link
Contributor Author

iAmShorty commented Jun 30, 2016

done 😎

changed the .travis.yml to the new composer plugin

@iAmShorty iAmShorty deleted the block-notification branch June 30, 2016 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants