Closing tags on development branch #2411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since files are often shared or re-used (via include(), require(), and their _once variants), any whitespace after the closing PHP tag can cause buffering issues, improper formatting for responses (like JSON or XML), broken Ajax requests, or problems with the timing of sending headers. Closing PHP tags are also prohibited by many style guides, including PSR-2, Zend Framework, Symfony, and CodeIgniter. I saw on Code Climate that many of your PHP-only files had closing PHP tags, many with a line of whitespace after it, so I cleaned these up. I also added the Code Climate badge to the readme.