Skip to content

Closing tags on development branch #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2015
Merged

Closing tags on development branch #2411

merged 3 commits into from
Apr 27, 2015

Conversation

e3betht
Copy link
Contributor

@e3betht e3betht commented Apr 27, 2015

Since files are often shared or re-used (via include(), require(), and their _once variants), any whitespace after the closing PHP tag can cause buffering issues, improper formatting for responses (like JSON or XML), broken Ajax requests, or problems with the timing of sending headers. Closing PHP tags are also prohibited by many style guides, including PSR-2, Zend Framework, Symfony, and CodeIgniter. I saw on Code Climate that many of your PHP-only files had closing PHP tags, many with a line of whitespace after it, so I cleaned these up. I also added the Code Climate badge to the readme.

@TheSerapher
Copy link
Contributor

Thanks! Good change and will now be part of 1.0.2!

TheSerapher added a commit that referenced this pull request Apr 27, 2015
Closing tags on development branch
@TheSerapher TheSerapher merged commit da8b3cc into MPOS:development Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants