Apply markdown engine to result provider #232
Conversation
|
This pull request introduces 3 alerts when merging 4bb9018 into bcafa92 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
Currently, the parsing does not cover this case: However, the If there is issue about it in the future, further logic can be added at that time. |
| return `<!DOCTYPE html> | ||
| <html lang="en"> | ||
| private parseResult(raw: string): IResult { | ||
| raw = raw.concat(" √ "); // Append a dummy sentinel to the end of raw string |
There was a problem hiding this comment.
What will happen if we don't append √?
There was a problem hiding this comment.
The RegEx captures anything in between two √. If we don't append it, the last section (normally stdout) won't be captured.
Worth to note that, with this trick, messages like [WARN] Failed to get memory percentile will be captured as one part of Your runtime beats 81.3 % of python submissions, and will also be printed out even it does not starts with √.
There was a problem hiding this comment.
Hmm... still feeling the logic here is too tricky for maintaince.
It's ok to merge for now.
Introduction
Solving #216 (comment)
Demonstration