Reflect: Fix regression with prototype of .has #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks.... and good news, the rhino based impl does not have this problem ;-) |
|
Sorry for the bug 🐛 |
|
will try to make a pr for the negative index handling this week and i have to finish the construct() impl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Reflect.hasis null, was caused by my previous Fix for Reflect's properties having an incorrect scope #594 [1][1] Moving the property initialization from
setParentScope()to the constructor broke initialization of newFunctionObjectinstances because the prototype is pulled from the parent scope.