WebResponse.getContentAsStreamWithBomIfApplicable() overriding is missing in WebResponseWrapper

[RuralHunter]

This causes css cache loading error. In CssStyleSheet, if the response is from cache, then the response is a WebResponseWrapper(extended from WebResponseWrapper) instance. Since the method getContentAsStreamWithBomIfApplicable() is not overriden in WebResponseWrapper, it actually calls the WebResponse.getContentAsStreamWithBomIfApplicable() which always returns null because it's only an empty delegator.

[rbri]

Hi @RuralHunter ,
had a first look at your problem. Sounds clear so far but i like to build a test case for this also. So far i have problems simulating your case.
Do you have any hint for this. My problem is to find a case where the

final Object fromCache = cache.getCachedObject(request);

does not detect the css as from cache but the repsonse itself is from the case.

[RuralHunter]

ah yes, this happens when I was trying to implement a FileCache, which only caches responses but not the parsed css objects. Looks it won't trigger the problem with the builtin cache since the response is always cleaned before the css object gets cleaned.

[rbri]

Ah ok will fix it soon

[RuralHunter]

Great!