Skip to content

Refactoring: Extract Class #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bharatwaaj
Copy link
Contributor

Refactoring: Extract Class

Reason for change:

The string utils class contained almost all string utils related to colours, and some method related to XML String, so there was an opportunity to split them into two separate classes as XMLStringUtils and StringUtils and they will contribute separately.

 

@rbri
Copy link
Member

rbri commented Mar 28, 2022

Ok, but how does this help in terms of

  • readability
  • mainainability?

@bharatwaaj
Copy link
Contributor Author

  1. The Readability increases as for the XML related string utils are concerned only at a specific spot.
  2. The maintainability will be easier going forward as there are more and more XML String utilities that gets in the way as the htmlUnit progresses.

@rbri
Copy link
Member

rbri commented Mar 30, 2022

Sorry i don't agree here.

@rbri rbri closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants