Skip to content

chore(fixit): Go Error Visibility for cloudsql/sqlserver/database-sql #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 17, 2023

Conversation

gotochkin
Copy link
Contributor

@gotochkin gotochkin commented May 16, 2023

…e listed files

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented May 16, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 16, 2023
@gotochkin gotochkin changed the title Replaced %v by %w as variable for all usage cases of fmt.Errorf in th… fixit: Go Error Visibility for cloudsql/sqlserver/database-sql May 16, 2023
@gotochkin gotochkin changed the title fixit: Go Error Visibility for cloudsql/sqlserver/database-sql chore(fixit): Go Error Visibility for cloudsql/sqlserver/database-sql May 16, 2023
@gotochkin gotochkin marked this pull request as ready for review May 16, 2023 15:23
@gotochkin gotochkin requested review from a team as code owners May 16, 2023 15:23
@gotochkin gotochkin enabled auto-merge (squash) May 17, 2023 14:53
@gotochkin gotochkin disabled auto-merge May 17, 2023 14:58
@telpirion telpirion self-assigned this May 17, 2023
@telpirion telpirion enabled auto-merge (squash) May 17, 2023 16:11
@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
@telpirion telpirion merged commit 20a8956 into main May 17, 2023
@telpirion telpirion deleted the fixit-errors-cloudsql-sqlserver branch May 17, 2023 17:25
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
rsamborski pushed a commit that referenced this pull request May 18, 2023
…#3060)

* Replaced %v by %w as variable for all usage cases of fmt.Errorf in the listed files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants