Skip to content

SAML21J18A: #endif without #if in analogout_api.c #9925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

SAML21J18A: #endif without #if in analogout_api.c #9925

merged 1 commit into from
Mar 15, 2019

Conversation

janjongboom
Copy link
Contributor

@janjongboom janjongboom commented Mar 4, 2019 •
edited
Loading

This PR: 3bd3aca#diff-995cd6fe18f4fabfb549266dde0a3784 broke the SAML21J18A target, as there was no #if DEVICE_ANALOGOUT call, and this PR added an #endif there that's not matched now.

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@janjongboom
SAML21J18A: #endif without #if in analogout_api.c
67b706a 
This PR: ARMmbed@3bd3aca#diff-995cd6fe18f4fabfb549266dde0a3784 broke the SAML21J18A target, as there was no `#if DEVICE_ANALOGOUT` call, and this PR added an `#endif` there that's not matched now.
@ciarmcom ciarmcom requested a review from a team March 4, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 4, 2019

@janjongboom, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019

cc @c1728p9

c1728p9
c1728p9 approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@c1728p9 c1728p9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @janjongboom

@janjongboom
Copy link
Contributor Author

@c1728p9 @0xc0170 cppcheck actually caught this as well. Maybe we should start using it more:

[targets/TARGET_Atmel/TARGET_SAM_CortexM0P/TARGET_SAML21J18A/analogout_api.c:122]: (error) #endif without #if

@cmonr
Copy link
Contributor

cmonr commented Mar 7, 2019

@janjongboom How long did it take to run cppcheck on the entire codebase? 😀

@janjongboom
Copy link
Contributor Author

@cmonr Not that long, maybe 15 minutes. But I found quite a lot of stuff through it already (even without configuring any macros / build options).

@0xc0170 0xc0170 mentioned this pull request Mar 14, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

No more changes are expected there.

This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit 67b706a into ARMmbed:master Mar 15, 2019
@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1 rollup PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@janjongboom @ciarmcom @0xc0170 @cmonr @c1728p9