Skip to content

Tests: check if recv returned too much data #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Tests: check if recv returned too much data #9905

merged 1 commit into from
Mar 15, 2019

Conversation

michalpasztamobica
Copy link
Contributor

Description

There are devices which happen to return more data than it was requested when TCPSocket::recv() is called. We need to add checks against this.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@juhoeskeli
@pekkapesu
@SeppoTakalo
@VeijoPesonen

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Mar 1, 2019

@michalpasztamobica, thank you for your changes.
@VeijoPesonen @SeppoTakalo @juhoeskeli @pekkapesu @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@michalpasztamobica
Copy link
Contributor Author

@juhoeskeli , @pekkapesu , would you let us know which platforms exactly were the ones causing issues? Perhaps we could run the PR on those targets as the devices we have available don't really trigger these errors.

VeijoPesonen
VeijoPesonen reviewed Mar 1, 2019
View reviewed changes
VeijoPesonen
VeijoPesonen reviewed Mar 1, 2019
View reviewed changes
VeijoPesonen
VeijoPesonen suggested changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my earlier comments.

@michalpasztamobica michalpasztamobica force-pushed the test_recv_return_less_or_equal branch from 8c09ebb to 47b5442 Compare March 1, 2019 15:04
@michalpasztamobica michalpasztamobica force-pushed the test_recv_return_less_or_equal branch from 47b5442 to c81f71b Compare March 1, 2019 16:01
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2019

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

io serial, restarting test

@0xc0170 0xc0170 merged commit 91b81c6 into ARMmbed:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@juhoeskeli juhoeskeli Awaiting requested review from juhoeskeli

@pekkapesu pekkapesu Awaiting requested review from pekkapesu

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michalpasztamobica @ciarmcom @0xc0170 @mbed-ci @cmonr @SeppoTakalo @VeijoPesonen