Skip to content

Fix multihoming tests #9875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix multihoming tests #9875

merged 1 commit into from
Mar 4, 2019

Conversation

tymoteuszblochmobica
Copy link
Contributor

@tymoteuszblochmobica tymoteuszblochmobica commented Feb 27, 2019 •
edited by 0xc0170
Loading

Description

Fixed test cases for multihoming.
This apply proper network interface instance verify.
It prevents crash if device doesn't have ethernet or wifi device.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo please review
@mikaleppanen please review
@kjbracey-arm please review

Release Notes

@tymoteuszblochmobica
Copy link
Contributor Author

@SeppoTakalo please review
@mikaleppanen please review
@kjbracey-arm please review

@tymoteuszblochmobica tymoteuszblochmobica changed the title Fix multihoming tests for case of no ethernet device Fix multihoming tests Feb 27, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2019

I updated Reviewers section (use that one to request reviewers, will be tagged automatically).

@ciarmcom
Copy link
Member

@tymoteuszblochmobica, thank you for your changes.
@SeppoTakalo @kjbracey-arm @mikaleppanen @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo
Copy link
Contributor

Should the whole test be flagged with #if DEVICE_EMAC
Because if that is not provided, you don't have proper Ethernet.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019

@tymoteuszblochmobica Can you rebase?

@0xc0170 0xc0170 requested a review from a user March 4, 2019 09:21
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019

Fixes release tests, marked for 5.12rc1

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019

@SeppoTakalo Please confirm, this is fixing feature tests, targeting 5.12 rc1

@tymoteuszblochmobica
Copy link
Contributor Author

Rebased

@NirSonnenschein
Copy link
Contributor

starting CI

@mbed-ci
Copy link

mbed-ci commented Mar 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170
0xc0170 approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would welcome better fix commit msg, but LGTM otherwise

@0xc0170 0xc0170 merged commit 355f09b into ARMmbed:master Mar 4, 2019
@tymoteuszblochmobica tymoteuszblochmobica deleted the testfix branch April 25, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

@mikaleppanen mikaleppanen Awaiting requested review from mikaleppanen

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tymoteuszblochmobica @0xc0170 @ciarmcom @SeppoTakalo @NirSonnenschein @mbed-ci