Re-enable MPS2 platform #9870

ChangwuShan · 2019-02-27T06:53:54Z

This pull request is about Re-enable MPS2 platform. It’s continuation of this closed pull request #7694 and add GCC_ARM and IAR support to those targets ( ARM_MPS2_M3, ARM_MPS2_M4 and ARM_MPS2_M7 ).

@ashok-rao

Pull request type

[x] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

ciarmcom · 2019-02-27T08:00:27Z

@ChangwuShan, thank you for your changes.
@ashok-rao @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-02-27T14:29:13Z

Can you share tests results for these targets?

Was this tested with IAR8 ? It's now enabled for master and upcoming 5.12.

ChangwuShan · 2019-02-28T07:53:23Z

Hi @0xc0170, may I ask which kind of test results do you need? I have tested all those targets with the Greentea test and all the tests passed.
I tested the targets with IAR7.5.

0xc0170 · 2019-02-28T08:24:38Z

I tested the targets with IAR7.5.

To be on the safe side, we should run IAR8.32 tests as well.

Hi @0xc0170, may I ask which kind of test results do you need? I have tested all those targets with the Greentea test and all the tests passed.

Tests you run, attach the logs here. For any new target (this is reenabled so treated as new target as was disabled for some reason) tests should be part of the PR.

ChangwuShan · 2019-03-08T02:35:23Z

Hi @0xc0170 , I got similar problems with this link #7733 when running IAR 8.32. Does Mbed support IAR8.X now?

cmonr · 2019-03-08T05:48:43Z

@ChangwuShan Yes, Mbed OS recently (finally) moved over to IAR 8.32 . Unfortunately, the switch was a hard switch due to some technical challenges.

ChangwuShan · 2019-03-12T02:49:56Z

Hi, the Greentea test logs are attached.
ARM_MPS2_M3_ARM.txt
ARM_MPS2_M3_GCC.txt
ARM_MPS2_M3_IAR.txt
ARM_MPS2_M4_ARM.txt
ARM_MPS2_M4_GCC.txt
ARM_MPS2_M4_IAR.txt
ARM_MPS2_M7_ARM.txt
ARM_MPS2_M7_GCC.txt
ARM_MPS2_M7_IAR.txt

0xc0170 · 2019-03-14T09:36:34Z

Changes look fine to me. As we discussed yesterday, M0 build issue should be fixed now, can you also attach M0 test logs?

@ashok-rao Waiting for your review

ashok-rao · 2019-03-14T11:21:44Z

@ChangwuShan : Thanks for this. Just for completeness, can you please also attach M0 & M0P test logs? Thanks.
@0xc0170 : Changes LGTM! Thanks.

0xc0170

Waiting for M0 confirmation all is tested and OK

ChangwuShan · 2019-03-18T08:45:19Z

Hi, test logs for M0:
ARM_MPS2_M0_ARM.txt
ARM_MPS2_M0_GCC_ARM.txt
ARM_MPS2_M0_IAR.txt
There are some timeout issues with M0P (ARMC6, GCC_ARM, IAR) , trying to fix it.

0xc0170 · 2019-03-18T09:43:24Z

@ChangwuShan Let us know. You can still enable rest of targets and separate PR for M0P with fixes.

ChangwuShan · 2019-03-20T06:12:49Z

Add GCC_ARM and IAR support for ARM_MPS2_M0P and ARM_MPS2_M0.

ChangwuShan · 2019-03-21T09:13:21Z

Test logs for ARM_MPS2_M0P
ARM_MPS_M0P_GCC_ARM.txt
ARM_MPS_M0P_IAR.txt
ARM_MPS_M0P_ARMC6.txt

cmonr · 2019-03-27T21:09:44Z

targets/targets.json

@@ -5116,15 +5117,16 @@
            "SERIAL",
            "SPI",
            "SPISLAVE",
-            "TSC",
-            "MPU"
+            "TSC"


I'm curious. What is TSC?

It is Touch Screen. This change is just to delete the "MPU", but I have to delete the comma behind "TSC".

cmonr · 2019-03-27T21:10:04Z

CI started

M0 logs provided

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN500(ARM_MPS2_M7). Add "IAR" to supported_toolchain list. Change-Id: I0b8f018fc937727382b27ea0669940ae6675c834 Signed-off-by: Shawn Shan <[email protected]>

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN386(ARM_MPS2_M4). Add "IAR" to supported_toolchain list. Change-Id: I4f43617c870197b9d39a4d4c9c12456adcc6f96f Signed-off-by: Shawn Shan <[email protected]>

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN385(ARM_MPS2_M3). Add "IAR" to supported_toolchain list. Change-Id: I038b05b8b21bd146a1568de897ed030ccd52ab79 Signed-off-by: Shawn Shan <[email protected]>

Add files MPS2.ld and startup_MPS2.S to support GCC_ARM of the target AN383(ARM_MPS2_M0P). Add "GCC_ARM" to supported_toolchains list. Change-Id: I48020b4f0f1b6e0aef3c53f5a3586bc9e9fca9c9 Signed-off-by: Shawn Shan <[email protected]>

Add files MPS2.ld and startup_MPS2.S to support GCC_ARM of the target AN382(ARM_MPS2_M0). Add "GCC_ARM" to supported_toolchains list. Change-Id: I7046b698834c82e94015e51eef9a0f5e1315ddaa Signed-off-by: Shawn Shan <[email protected]>

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN383(ARM_MPS2_M0P). Add "IAR" to supported_toolchain list. Change-Id: Ib2278d34e265e53ad070aecd318ed4e6a355e3c0 Signed-off-by: Shawn Shan <[email protected]>

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN382(ARM_MPS2_M0). Add "IAR" to supported_toolchain list. Change-Id: I2b2ad7645166c4f973a8baa9c394521514183767 Signed-off-by: Shawn Shan <[email protected]>

Change-Id: I0205d381de331a827435d667c16297aaf5bb609e Signed-off-by: Shawn Shan <[email protected]>

0xc0170 · 2019-04-15T10:06:38Z

CI started

mbed-ci · 2019-04-15T18:06:43Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage
jenkins-ci/mbed-os-ci_greentea-test

alekla01 · 2019-04-15T18:58:04Z

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

alekla01 · 2019-04-15T19:03:37Z

restarted jenkins-ci/greentea-test

0xc0170 · 2019-04-16T07:44:54Z

@ashok-rao Final review please

ashok-rao

LGTM! Thanks @ChangwuShan

mbed-ci · 2019-04-17T05:17:48Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

ciarmcom requested review from ashok-rao and a team February 27, 2019 08:00

ciarmcom added the needs: review label Feb 27, 2019

0xc0170 added the scope: new-target label Feb 27, 2019

cmonr added needs: work release-version: 5.12.1 and removed needs: review labels Feb 28, 2019

cmonr added needs: review and removed needs: work labels Mar 12, 2019

0xc0170 previously requested changes Mar 14, 2019

View reviewed changes

ChangwuShan mentioned this pull request Mar 18, 2019

Enable IAR and GCC_ARM support for ARM_MPS2_M0 #10141

Closed

ChangwuShan force-pushed the Re-enable_MPS2_platform branch from 760d56a to 386f625 Compare March 20, 2019 06:10

cmonr requested review from 0xc0170 and cmonr March 25, 2019 20:09

cmonr approved these changes Mar 27, 2019

View reviewed changes

ChangwuShan added 8 commits April 15, 2019 16:56

Add IAR support for the target AN500 of MPS2.

063d5dc

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN500(ARM_MPS2_M7). Add "IAR" to supported_toolchain list. Change-Id: I0b8f018fc937727382b27ea0669940ae6675c834 Signed-off-by: Shawn Shan <[email protected]>

Add IAR support for the target AN386 of MPS2.

151d6e0

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN386(ARM_MPS2_M4). Add "IAR" to supported_toolchain list. Change-Id: I4f43617c870197b9d39a4d4c9c12456adcc6f96f Signed-off-by: Shawn Shan <[email protected]>

Add IAR support for the target AN385 of MPS2.

0dbaeef

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN385(ARM_MPS2_M3). Add "IAR" to supported_toolchain list. Change-Id: I038b05b8b21bd146a1568de897ed030ccd52ab79 Signed-off-by: Shawn Shan <[email protected]>

Add GCC_ARM support for the target AN383 of MPS2.

db57e58

Add files MPS2.ld and startup_MPS2.S to support GCC_ARM of the target AN383(ARM_MPS2_M0P). Add "GCC_ARM" to supported_toolchains list. Change-Id: I48020b4f0f1b6e0aef3c53f5a3586bc9e9fca9c9 Signed-off-by: Shawn Shan <[email protected]>

Add GCC_ARM support for the target AN382 of MPS2.

b268aa6

Add files MPS2.ld and startup_MPS2.S to support GCC_ARM of the target AN382(ARM_MPS2_M0). Add "GCC_ARM" to supported_toolchains list. Change-Id: I7046b698834c82e94015e51eef9a0f5e1315ddaa Signed-off-by: Shawn Shan <[email protected]>

Add IAR support for the target AN383 of MPS2.

b3ee6cb

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN383(ARM_MPS2_M0P). Add "IAR" to supported_toolchain list. Change-Id: Ib2278d34e265e53ad070aecd318ed4e6a355e3c0 Signed-off-by: Shawn Shan <[email protected]>

Add IAR support for the target AN382 of MPS2.

6374790

Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target AN382(ARM_MPS2_M0). Add "IAR" to supported_toolchain list. Change-Id: I2b2ad7645166c4f973a8baa9c394521514183767 Signed-off-by: Shawn Shan <[email protected]>

Fix the build failed issue of MPS2 targets with ARMC6.

3d9b7df

Change-Id: I0205d381de331a827435d667c16297aaf5bb609e Signed-off-by: Shawn Shan <[email protected]>

ChangwuShan force-pushed the Re-enable_MPS2_platform branch from 2c0ea89 to 3d9b7df Compare April 15, 2019 09:59

0xc0170 added needs: CI and removed needs: work labels Apr 15, 2019

0xc0170 added needs: review and removed needs: CI labels Apr 16, 2019

ashok-rao approved these changes Apr 16, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Apr 16, 2019

0xc0170 changed the title ~~Re enable mps2 platform~~ Re-enable MPS2 platform Apr 16, 2019

0xc0170 added ready for merge and removed needs: CI labels Apr 17, 2019

0xc0170 merged commit c961a5d into ARMmbed:master Apr 17, 2019

0xc0170 removed the ready for merge label Apr 17, 2019

adbridge added release-version: 5.12.1 release-version: 5.12.2 and removed release-version: 5.12.1 labels Apr 24, 2019

Re-enable MPS2 platform #9870

Re-enable MPS2 platform #9870

Uh oh!

Conversation

ChangwuShan commented Feb 27, 2019

Pull request type

Uh oh!

ciarmcom commented Feb 27, 2019

Uh oh!

0xc0170 commented Feb 27, 2019

Uh oh!

ChangwuShan commented Feb 28, 2019

Uh oh!

0xc0170 commented Feb 28, 2019

Uh oh!

ChangwuShan commented Mar 8, 2019

Uh oh!

cmonr commented Mar 8, 2019

Uh oh!

ChangwuShan commented Mar 12, 2019

Uh oh!

0xc0170 commented Mar 14, 2019

Uh oh!

ashok-rao commented Mar 14, 2019

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

ChangwuShan commented Mar 18, 2019

Uh oh!

0xc0170 commented Mar 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChangwuShan commented Mar 20, 2019

Uh oh!

ChangwuShan commented Mar 21, 2019

Uh oh!

cmonr Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

ChangwuShan Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 27, 2019

Uh oh!

0xc0170 commented Apr 15, 2019

Uh oh!

mbed-ci commented Apr 15, 2019

Test run: FAILED

Uh oh!

alekla01 commented Apr 15, 2019

Uh oh!

alekla01 commented Apr 15, 2019

Uh oh!

0xc0170 commented Apr 16, 2019

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Apr 17, 2019

Test run: SUCCESS

Uh oh!

Uh oh!

0xc0170 commented Mar 18, 2019 •

edited

Loading