Skip to content

Apply artifact_name configuration parameter to exported projects #9817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2019
Merged

Apply artifact_name configuration parameter to exported projects #9817

merged 4 commits into from
Mar 1, 2019

Conversation

kegilbert
Copy link
Contributor

Description

#8428

Previously the artifact_name parameter was not used when exporting projects. I just slipped this little guy in as it should cover all use cases, let me know if I missed something though as I'm a bit less familiar with this section of the tools!

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy
@bridadan

Release Notes

@kegilbert kegilbert force-pushed the artifact_name_export branch from d498ef2 to 056b88a Compare February 22, 2019 23:47
theotherjimmy
theotherjimmy previously requested changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a property that does this in the config class. That way we don't have to use this constant in multiple places.

@NirSonnenschein NirSonnenschein requested review from a team February 25, 2019 08:00
@cmonr cmonr requested a review from theotherjimmy February 25, 2019 22:30
cmonr
cmonr reviewed Feb 25, 2019
View reviewed changes
@cmonr
Copy link
Contributor

cmonr commented Feb 25, 2019

CI started

@cmonr cmonr dismissed theotherjimmy’s stale review February 26, 2019 00:01

Suggestions used. Please re-review.

@cmonr
Copy link
Contributor

cmonr commented Feb 26, 2019 •
edited
Loading

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 26, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2019

This will need restarting CI

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@cmonr
Copy link
Contributor

cmonr commented Feb 28, 2019

Info: A CI config issue appears to be affecting NUMAKER_PFM_M2351 builds. Please ignore build errors against the target for now.

Other build failures should still be investigated, if any. Will restart CI when appropriate.

@cmonr cmonr added the risk: A label Feb 28, 2019
@mbed-ci
Copy link

mbed-ci commented Feb 28, 2019

Test run: FAILED

Summary: 2 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC6
  • jenkins-ci/mbed-os-ci_build-ARMC6

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2019

Test run: FAILED

Summary: 2 of 9 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARMC5

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2019 •
edited
Loading

We are testing the CI fix (the last 2 failures) another run in CI now

@alekla01
Copy link
Contributor

Restarted CI & Restarted greentea-test.

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Mar 1, 2019

Fyi, jenkins-ci/mbed-os-ci_greentea-test was restarted and passed.

@cmonr cmonr merged commit 460e4e7 into ARMmbed:master Mar 1, 2019
@kegilbert kegilbert mentioned this pull request Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy Awaiting requested review from theotherjimmy

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1 risk: A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kegilbert @cmonr @mbed-ci @0xc0170 @alekla01 @theotherjimmy @NirSonnenschein