Increase events.share-eventsize to 768B because of ESP8266 AT driver and asynchronous DNS #9799

VeijoPesonen · 2019-02-21T15:43:23Z

Description

events.shared-eventsize: increased from 256B to 768B

Original value was too small once both ESP8266 driver and
asynchronous DNS started to use shared event queue. An assumption is
made that once shared event queue is taken into use there are going to
be multiple users instead of one, for which the original value would
have been sufficient.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm
@SeppoTakalo
@geky
@michalpasztamobica

Release Notes

"events.shared-eventsize" increased from 256B to 768B

Original value was too small once both ESP8266 driver and
asynchronous DNS started to use shared event queue. An assumption is
made that once shared event queue is taken into use there are going to
be multiple users instead of one, for which the original value would
have been sufficient.

VeijoPesonen · 2019-02-21T15:53:30Z

mbedgt: test case report:

| target              | platform_name | test suite          | test case                             | passed | failed | result | elapsed_time (sec) |
|---------------------|---------------|---------------------|---------------------------------------|--------|--------|--------|--------------------|
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS                      | 1      | 0      | OK     | 0.28               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_CACHE                | 1      | 0      | OK     | 0.62               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_CANCEL               | 1      | 0      | OK     | 5.35               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_EXTERNAL_EVENT_QUEUE | 1      | 0      | OK     | 3.13               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_INVALID_HOST         | 1      | 0      | OK     | 1.15               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_NON_ASYNC_AND_ASYNC  | 1      | 0      | OK     | 0.79               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_SIMULTANEOUS         | 1      | 0      | OK     | 0.75               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_SIMULTANEOUS_CACHE   | 1      | 0      | OK     | 0.75               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT  | 1      | 0      | OK     | 4.95               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | ASYNCHRONOUS_DNS_TIMEOUTS             | 1      | 0      | OK     | 7.8                |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | SYNCHRONOUS_DNS                       | 1      | 0      | OK     | 0.1                |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | SYNCHRONOUS_DNS_INVALID               | 1      | 0      | OK     | 1.31               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-netsocket-dns | SYNCHRONOUS_DNS_MULTIPLE              | 1      | 0      | OK     | 0.61               |
mbedgt: test case results: 13 OK
mbedgt: completed in 88.79 sec

ciarmcom · 2019-02-21T16:00:49Z

@VeijoPesonen, thank you for your changes.
@geky @SeppoTakalo @kjbracey-arm @ARMmbed/mbed-os-core @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

SeppoTakalo · 2019-02-21T16:03:59Z

features/netsocket/NetworkStack.cpp

        }
    }
-
-    return NSAPI_ERROR_OK;
+EXIT:


Make this block name as NO_MEM, and get rid of the "ret = " temporary variable, as it serves no purpose.

VeijoPesonen · 2019-02-22T10:56:56Z

@teetak01, @simosillankorva for your information

cmonr · 2019-02-22T17:26:46Z

@VeijoPesonen A style nit, but should be good to go afterwards: https://travis-ci.org/ARMmbed/mbed-os/jobs/496917472

VeijoPesonen · 2019-02-25T07:29:01Z

@cmonr fixed. I should stop wasting other people's time and run the check myself...

git diff --name-only --diff-filter=d `git merge-base HEAD master`..HEAD | ( grep '.$c\|cpp\|h\|hpp$$' || true ) | ( fgrep -v -f .astyleignore || true ) | while read file; do astyle -n --options=.astylerc "${file}"; done

0xc0170 · 2019-02-25T09:36:13Z

Waiting for final reviews, started CI meanwhile

mbed-ci · 2019-02-25T09:39:29Z

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests

VeijoPesonen · 2019-02-25T10:38:00Z

@0xc0170 , from CMakeError.log. ~~I would like to say this isn't due to my changes.~~ My mistake. Would you please rerun the tests if possible.

Determining if the pthread_create exist failed with the following output:
Change Dir: /builds/ws/mbed-os-ci_unittests/unitTest-2237/mbed-os/build/CMakeFiles/CMakeTmp

Run Build Command:"make" "cmTC_a0f5e/fast"
make -f CMakeFiles/cmTC_a0f5e.dir/build.make CMakeFiles/cmTC_a0f5e.dir/build
make[1]: Entering directory '/builds/ws/mbed-os-ci_unittests/unitTest-2237/mbed-os/build/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_a0f5e.dir/CheckSymbolExists.c.o
/usr/bin/gcc-5     -o CMakeFiles/cmTC_a0f5e.dir/CheckSymbolExists.c.o   -c /builds/ws/mbed-os-ci_unittests/unitTest-2237/mbed-os/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c
Linking C executable cmTC_a0f5e
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_a0f5e.dir/link.txt --verbose=1
/usr/bin/gcc-5       CMakeFiles/cmTC_a0f5e.dir/CheckSymbolExists.c.o  -o cmTC_a0f5e -rdynamic 
CMakeFiles/cmTC_a0f5e.dir/CheckSymbolExists.c.o: In function `main':
CheckSymbolExists.c:(.text+0x16): undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status
CMakeFiles/cmTC_a0f5e.dir/build.make:97: recipe for target 'cmTC_a0f5e' failed
make[1]: *** [cmTC_a0f5e] Error 1
make[1]: Leaving directory '/builds/ws/mbed-os-ci_unittests/unitTest-2237/mbed-os/build/CMakeFiles/CMakeTmp'
Makefile:126: recipe for target 'cmTC_a0f5e/fast' failed
make: *** [cmTC_a0f5e/fast] Error 2

File /builds/ws/mbed-os-ci_unittests/unitTest-2237/mbed-os/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:
/* */
#include <pthread.h>

int main(int argc, char** argv)
{
  (void)argv;
#ifndef pthread_create
  return ((int*)(&pthread_create))[argc];
#else
  (void)argc;
  return 0;
#endif
}

michalpasztamobica · 2019-02-25T14:26:32Z

@VeijoPesonen , I think the failure is due to using mbed_error in NetworkStack.
Fortunately there is already a stub in UNITTESTS/stubs/mbed_error.c and you probably just need to add it to UNITTESTS/features/netsocket/TCPSocket/unittest.cmake (and other unit tests cmake files).

cmonr · 2019-02-25T17:08:24Z

CI started

mbed-ci · 2019-02-25T17:11:53Z

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests

VeijoPesonen · 2019-02-26T06:50:02Z

Thanks @michalpasztamobica , wouldn't have crossed my mind the issue would be something like that.

Original value was too small once both ESP8266 driver and asynchronous DNS started to use shared event queue. An assumption is made that once shared event queue is taken into use there are going to be multiple users instead of one, for which the original value would have been sufficient.

VeijoPesonen · 2019-02-26T07:49:38Z

100% tests passed, 0 tests failed out of 43

Fixed, thanks @michalpasztamobica. @cmonr , would you please restart the CI.

bulislaw · 2019-02-26T15:10:44Z

This PR is at risk of missing 5.12 release as it's marked as "needs: work". Code freeze is coming! On Friday 1st. Please made necessary updates ASAP and make sure the reviewers are aligned for prompt code inspection.

cmonr · 2019-02-27T05:24:39Z

CI started

mbed-ci · 2019-02-27T10:23:17Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

VeijoPesonen changed the title ~~Increase events.share-eventsize to 768B because of ESP8266 AT driver and asynchronous DNS~~ Increase events.share-eventsize to 768kB because of ESP8266 AT driver and asynchronous DNS Feb 21, 2019

VeijoPesonen changed the title ~~Increase events.share-eventsize to 768kB because of ESP8266 AT driver and asynchronous DNS~~ Increase events.share-eventsize to 768B because of ESP8266 AT driver and asynchronous DNS Feb 21, 2019

ciarmcom requested review from geky, kjbracey, SeppoTakalo and a team February 21, 2019 16:00

ciarmcom added the needs: review label Feb 21, 2019

SeppoTakalo reviewed Feb 21, 2019

View reviewed changes

cmonr added needs: work and removed needs: review labels Feb 21, 2019

cmonr added needs: review and removed needs: work labels Feb 22, 2019

cmonr approved these changes Feb 22, 2019

View reviewed changes

SeppoTakalo approved these changes Feb 22, 2019

View reviewed changes

0xc0170 requested a review from michalpasztamobica February 25, 2019 09:35

0xc0170 added release-version: 5.12.0-rc1 risk: G needs: CI and removed needs: review labels Feb 25, 2019

0xc0170 added needs: work and removed needs: CI labels Feb 25, 2019

michalpasztamobica approved these changes Feb 25, 2019

View reviewed changes

cmonr added needs: CI and removed needs: work labels Feb 25, 2019

cmonr added needs: work risk: A and removed risk: G needs: CI labels Feb 25, 2019

Veijo Pesonen added 3 commits February 26, 2019 09:44

NetworkStack: halts if unable to add an event to the event queue

517799f

ESP8266: halts if unable to add an event to the event queue

2e5d1d9

michalpasztamobica approved these changes Feb 26, 2019

View reviewed changes

cmonr added needs: CI and removed needs: work labels Feb 27, 2019

0xc0170 added ready for merge and removed needs: CI labels Feb 27, 2019

0xc0170 merged commit 6bdbe75 into ARMmbed:master Feb 27, 2019

0xc0170 removed the ready for merge label Feb 27, 2019

VeijoPesonen deleted the bugfix-esp8266-dns branch February 27, 2019 10:45

Increase events.share-eventsize to 768B because of ESP8266 AT driver and asynchronous DNS #9799

Increase events.share-eventsize to 768B because of ESP8266 AT driver and asynchronous DNS #9799

Uh oh!

Conversation

VeijoPesonen commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

VeijoPesonen commented Feb 21, 2019

mbedgt: test case report:

Uh oh!

ciarmcom commented Feb 21, 2019

Uh oh!

SeppoTakalo Feb 21, 2019

Choose a reason for hiding this comment

Uh oh!

VeijoPesonen Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

VeijoPesonen commented Feb 22, 2019

Uh oh!

cmonr commented Feb 22, 2019

Uh oh!

VeijoPesonen commented Feb 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Feb 25, 2019

Uh oh!

mbed-ci commented Feb 25, 2019

Test run: FAILED

Uh oh!

VeijoPesonen commented Feb 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michalpasztamobica commented Feb 25, 2019

Uh oh!

cmonr commented Feb 25, 2019

Uh oh!

mbed-ci commented Feb 25, 2019

Test run: FAILED

Uh oh!

VeijoPesonen commented Feb 26, 2019

Uh oh!

VeijoPesonen commented Feb 26, 2019

Uh oh!

bulislaw commented Feb 26, 2019

Uh oh!

cmonr commented Feb 27, 2019

Uh oh!

mbed-ci commented Feb 27, 2019

Test run: SUCCESS

Uh oh!

Uh oh!

VeijoPesonen commented Feb 21, 2019 •

edited

Loading

VeijoPesonen commented Feb 25, 2019 •

edited

Loading

VeijoPesonen commented Feb 25, 2019 •

edited

Loading