Skip to content

Refactor psa entropy inject test #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2019
Merged

Refactor psa entropy inject test #9701

merged 2 commits into from
Feb 13, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Feb 13, 2019

Description

Replace TEST_ASSERT with more specific assertions

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from a team February 13, 2019 10:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team February 13, 2019 10:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

Patater
Patater reviewed Feb 13, 2019
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring looks good, thanks.

I have questions about the new device lifetime function call and assert.

Oren Cohen added 2 commits February 13, 2019 14:20
Refactor psa entropy inject test
6bb0894 
Replace TEST_ASSERT with more specific assertions
Clear ITS environment in psa entropy tests
eb48d3c 
mbed_psa_reboot_and_request_new_security_state() API replaced its_reset() which is now a secure API only

This change is necessary for a clean environment for the test
@orenc17
Copy link
Contributor Author

orenc17 commented Feb 13, 2019

@Patater changed the commit message as requested

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019 •
edited
Loading

CI started.

Will wait on @teetak01 to ack before merging

Sorry, wrong PR.

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit da57191 into ARMmbed:master Feb 13, 2019
@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater left review comments

@cmonr cmonr cmonr approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orenc17 @ciarmcom @cmonr @mbed-ci @Patater @NirSonnenschein