Make a few trivial syntactic changes to better support cross-compilation #9681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NeilMacMullen, thank you for your changes. |
|
@NeilMacMullen, thank you for your changes. |
cmonr
approved these changes
Feb 12, 2019
|
CI started whist final review comes in. Betting on reviewer being OK with changes |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
jarvte
approved these changes
Feb 13, 2019
AnttiKauppila
approved these changes
Feb 13, 2019
hasnainvirk
reviewed
Feb 13, 2019
| @@ -990,7 +990,7 @@ void AT_CellularSMS::add_info(sms_info_t *info, int index, int part_number) | |||
| return; | |||
| } | |||
| sms_info_t *current = _sms_info; | |||
| sms_info_t *prev; | |||
| sms_info_t *prev=NULL; | |||
There was a problem hiding this comment.
This may fail on astyle check.
sms_info_t *prev = NULL:will pass.
There was a problem hiding this comment.
thanks - already fixed on second commit
|
Patch application did not like this attempting to be applied onto It could be that this is sitting on top of the cellular refactor. Retargeting for 5.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's much easier to debug the cellular stack when cross-compiled to desktop. This PR cleans up a couple of warnings/errors under Visual C++ to simplify cross-compilation.
Pull request type
Reviewers