Skip to content

Revert "MIMXRT1050_EVK: Add IAR support in the exporter" #9657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2019
Merged

Revert "MIMXRT1050_EVK: Add IAR support in the exporter" #9657

merged 1 commit into from
Feb 11, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 11, 2019 •
edited
Loading

Description

Reverts #9496

Reason: MCU is only available in IAR 8.22 and higher. Please see 9610 for more details

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 mentioned this pull request Feb 11, 2019
Closed
@ciarmcom ciarmcom requested review from a team February 11, 2019 10:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 removed the request for review from a team February 11, 2019 10:03
@ciarmcom ciarmcom requested a review from a team February 11, 2019 12:00
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 11, 2019

To fix the nightly, I started CI

@adbridge
Copy link
Contributor

@0xc0170 Please add the missing template header ;-)

bridadan
bridadan approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves are fine. Just be sure we don't forget to put this back once we have IAR 8 support!

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 11, 2019 •
edited
Loading

@0xc0170 Please add the missing template header ;-)

Not sure how that happen , fixed now

It could be if revert via github, it wont catch the template? or I just removed it when typing

@ARMmbed ARMmbed deleted a comment from ciarmcom Feb 11, 2019
@ARMmbed ARMmbed deleted a comment from ciarmcom Feb 11, 2019
@mbed-ci
Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 760aadf into master Feb 11, 2019
@0xc0170 0xc0170 deleted the revert-9496-Add_MXRT_IAR_Support branch February 12, 2019 08:04
@mmahadevan108 mmahadevan108 mentioned this pull request Apr 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xc0170 @ciarmcom @adbridge @mbed-ci @cmonr @bridadan