Skip to content

Change TESTS/netsocket/ for cellular testing #9645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

Change TESTS/netsocket/ for cellular testing #9645

merged 1 commit into from
Feb 13, 2019

Conversation

AriParkkila
Copy link

Description

Change TESTS/netsocket/ for cellular testing:

  • Test loops reduced and timings increased for cellular network slowness
  • Network disconnect added at the end of DNS test suite
  • Socket send/receive asynchronous handlers fixed
  • Network configuration for CellularInterface

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@VeijoPesonen

@ciarmcom ciarmcom requested review from VeijoPesonen and a team February 8, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 8, 2019

@AriParkkila, thank you for your changes.
@VeijoPesonen @ARMmbed/mbed-os-test @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

bridadan
bridadan reviewed Feb 8, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only config has changed, I don't believe this needs tool team approval.

@AriParkkila
Copy link
Author

@VeijoPesonen os.mbed.com seems to fail for tls-handshake-invalid (at least occasionally), should we use mbed.com in that test case?

@VeijoPesonen
Copy link
Contributor

@VeijoPesonen os.mbed.com seems to fail for tls-handshake-invalid (at least occasionally), should we use mbed.com in that test case?
@michalpasztamobica , you have an opinion on this one? I haven't done anything for TLSSocket cases myself.

VeijoPesonen
VeijoPesonen reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changed values to the netsocket test case specification - TESTS/netsocket/README.md.

TESTS/netsocket/tls/tlssocket_handshake_invalid.cpp Outdated
@@ -32,7 +32,7 @@ void TLSSOCKET_HANDSHAKE_INVALID()
TEST_ASSERT_EQUAL(NSAPI_ERROR_OK, sock.open(NetworkInterface::get_default_instance()));
TEST_ASSERT_EQUAL(NSAPI_ERROR_OK, sock.set_root_ca_cert(tls_global::cert));
TEST_ASSERT_EQUAL(NSAPI_ERROR_NO_CONNECTION,
sock.connect("google.com", MBED_CONF_APP_ECHO_SERVER_DISCARD_PORT_TLS));
sock.connect("os.mbed.com", MBED_CONF_APP_ECHO_SERVER_DISCARD_PORT_TLS));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalpasztamobica. @SeppoTakalo there was a reason to use google.com?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have something to do with IPv6 address resolution, see the comment #9387 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, os.mbed.com does not accept IPv6 traffic which means it will fail with a different error than we expect. Google.com accepts Ipv6 traffic but will fail due to invalid certificate (which is what we want to test).

@AriParkkila
Copy link
Author

@michalpasztamobica @VeijoPesonen thanks reverted back to google.com.

michalpasztamobica
michalpasztamobica suggested changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the TLSSOCKET_HANDHSAKE_INVALID connection back to os.mbed.com. It has to stay with google.com (or some other IPv6-compliant webpage) to pass Nanostack and LWIP6 tests. If necessary, please adjust the documentation. Thanks!

michalpasztamobica
michalpasztamobica approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw your changes, thanks a lot :)

SeppoTakalo
SeppoTakalo reviewed Feb 11, 2019
View reviewed changes
SeppoTakalo
SeppoTakalo suggested changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes requested

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 2e9d6d2 into ARMmbed:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridadan bridadan bridadan left review comments

@VeijoPesonen VeijoPesonen VeijoPesonen left review comments

@SeppoTakalo SeppoTakalo SeppoTakalo requested changes

@cmonr cmonr cmonr approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@AriParkkila @ciarmcom @VeijoPesonen @cmonr @mbed-ci @SeppoTakalo @bridadan @michalpasztamobica @0xc0170