Skip to content

Use an ip4- and ip6-compliant site to test TLS certificate error reporting #9572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

Use an ip4- and ip6-compliant site to test TLS certificate error reporting #9572

merged 1 commit into from
Feb 1, 2019

Conversation

michalpasztamobica
Copy link
Contributor

Description

So far we used os.mbed.com to test that an incorrect (but valid) TLS certificate fails when trying to establish a connection. os.mbed.com is not ipv6-compliant, so it has to be changed for some other website that will also be able to reject our certificate. Google.com is a safe choice, it rejects our certificate and is very stable.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from a team January 31, 2019 14:00
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@michalpasztamobica
Copy link
Contributor Author

Travis failure is not related to the changes.

@cmonr
Copy link
Contributor

cmonr commented Jan 31, 2019

@michalpasztamobica I'll be so glad once apt-get usage is removed from Travis...

If that happens again, feel free to restart the Travis CI job. apt-get issues tend to be intermitent.

@cmonr
Copy link
Contributor

cmonr commented Jan 31, 2019

CI started by @0xc0170

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 3d4582b into ARMmbed:master Feb 1, 2019
@michalpasztamobica michalpasztamobica deleted the greentea_tls_ipv6_compliant_website branch February 1, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michalpasztamobica @ciarmcom @cmonr @mbed-ci @0xc0170 @SeppoTakalo