ESP8266: treats reset-ready-message as OOB #9473

VeijoPesonen · 2019-01-23T14:09:29Z

Description

Makes possible to detect if modem gets reset by handling the reset-ready-message as OOB.

Fixes the network status update callback to not report a state change if a state change hasn't really occurred.

Prevent's running reset twice in a row if reset pin is connected to a known pin.

Fixes UART HW flow control enabling sequence - adds also mutex.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@michalpasztamobica
@kjbracey-arm

components/wifi/esp8266-driver/ESP8266/ESP8266.cpp

ciarmcom · 2019-01-23T16:00:49Z

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @kjbracey-arm @michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

cmonr · 2019-01-29T22:47:14Z

CI started

mbed-ci · 2019-01-30T03:19:36Z

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

cmonr · 2019-01-30T04:07:53Z

Restarted CI job: jenkins-ci/mbed-os-ci_dynamic-memory-usage

The wifi test failed, but it's not clear why.

VeijoPesonen · 2019-01-30T13:21:40Z

@cmonr Rebased.

cmonr · 2019-01-31T04:49:43Z

CI started

mbed-ci · 2019-01-31T09:35:14Z

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

0xc0170 · 2019-01-31T14:02:24Z

Restarted dynamic usage, but still can you check the artifacts to confirm the failure not related?

VeijoPesonen · 2019-01-31T14:39:13Z

Need to admit that the test results doesn't tell me much

[1548944538.40][HTST][INF] host test detected: default_auto
[1548944548.45][CONN][INF] found KV pair in stream: {{max_heap_usage;720}}, queued...
[1548944548.45][CONN][INF] found KV pair in stream: {{reserved_heap;183360}}, queued...
[1548944548.45][HTST][ERR] orphan event in main phase: {{max_heap_usage;720}}, timestamp=1548944548.451403
[1548944548.45][HTST][ERR] orphan event in main phase: {{reserved_heap;183360}}, timestamp=1548944548.451410
[1548944548.55][CONN][INF] found KV pair in stream: {{__thread_info;"0x020001738",1160,4096}}, queued...
[1548944548.55][CONN][INF] found KV pair in stream: {{__thread_info;"0x020001888",80,512}}, queued...
[1548944548.55][HTST][ERR] orphan event in main phase: {{__thread_info;"0x020001738",1160,4096}}, timestamp=1548944548.551406
[1548944548.55][CONN][INF] found KV pair in stream: {{__thread_info;"0x0200008ac",224,2048}}, queued...
[1548944548.55][HTST][ERR] orphan event in main phase: {{__thread_info;"0x020001888",80,512}}, timestamp=1548944548.551413
[1548944548.55][HTST][ERR] orphan event in main phase: {{__thread_info;"0x0200008ac",224,2048}}, timestamp=1548944548.551416
[1548944548.65][CONN][INF] found KV pair in stream: {{__thread_info;"0x020001844",104,768}}, queued...
[1548944548.65][CONN][INF] found KV pair in stream: {{end;failure}}, queued...
[1548944548.65][CONN][INF] found KV pair in stream: {{__exit;0}}, queued...
[1548944548.65][HTST][ERR] orphan event in main phase: {{__thread_info;"0x020001844",104,768}}, timestamp=1548944548.652407
[1548944548.65][HTST][INF] __exit(0)
[1548944548.65][HTST][INF] __notify_complete(False)
[1548944548.65][HTST][INF] __exit_event_queue received
[1548944548.65][HTST][INF] test suite run finished after 10.35 sec...
[1548944548.65][CONN][INF] received special event '__host_test_finished' value='True', finishing
[1548944548.65][urllib3.connectionpool]Starting new HTTP connection (1): ronja.mbedcloudtesting.com:80
[1548944548.87][urllib3.connectionpool]http://ronja.mbedcloudtesting.com:80 "PUT /resource/0311000040214e45003e1018c89200559e11000097969900/disconnect HTTP/1.1" 200 87
[1548944548.88][urllib3.connectionpool]Starting new HTTP connection (1): ronja.mbedcloudtesting.com:80
[1548944552.15][urllib3.connectionpool]http://ronja.mbedcloudtesting.com:80 "PUT /resource/0311000040214e45003e1018c89200559e11000097969900/release HTTP/1.1" 200 87
[1548944552.15][HTST][INF] CONN exited with code: 0
[1548944552.15][HTST][INF] Some events in queue
[1548944552.15][HTST][INF] stopped consuming events
[1548944552.15][HTST][INF] host test result() call skipped, received: False
[1548944552.15][HTST][INF] calling blocking teardown()
[1548944552.15][HTST][INF] teardown() finished
[1548944552.15][HTST][INF] {{result;failure}}
mbedgt: retry mbedhtrun 1/1
mbedgt: ['mbedhtrun', '-m', 'K66F', '-p', 'DUMMY:9600', '-f', u'"BUILD/dynamic/K66F/GCC_ARM/wifi/wifi.bin"', '--grm', 'raas_client:ronja.mbedcloudtesting.com:80', '-C', '4', '--sync', '5', '--tag-filters', 'MEMORY', '-P', '600'] failed after 1 count
mbedgt: checking for GCOV data...
mbedgt: mbed-host-test-runner: stopped and returned 'FAIL'
mbedgt: test case summary event not found
	no test case report present, assuming test suite to be a single test case!
	test suite: wifi
	test case: wifi
mbedgt: test on hardware with target id: DUMMY
mbedgt: test suite 'wifi' ............................................................................ FAIL in 41.72 sec
	test case: 'wifi' ............................................................................ FAIL in 41.72 sec

cmonr · 2019-01-31T16:28:57Z

@ARMmbed/mbed-os-test-team Can you help out with this one? Not sure why jenkins-ci/dynamic-memory-usage has repeatedly failed.

0xc0170 · 2019-02-01T08:06:00Z

@VeijoPesonen to unblock this, can you talk to @timurh01 ?

VeijoPesonen · 2019-02-01T12:15:41Z

@0xc0170 I'll run the test manually to see what is wrong.

VeijoPesonen · 2019-02-04T07:58:33Z

This requires some further investigation from me as I get same results with manual testing, but once I switch to NRF52840_DK(with ESP8266) - which I used to create this PR - test is passing.

mbedgt: test on hardware with target id: 110200004420312043574641323034203830303697969903
mbedgt: test suite 'wifi' ............................................................................ OK in 64.30 sec
        test case: 'wifi' ............................................................................ OK in 64.30 sec
mbedgt: test case summary: 1 pass, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.4552342797
mbedgt: exporting to JSON 'greentea-report.json'...
mbedgt: exporting memory metrics to CSV file 'memory_usage_temp.csv'...
mbedgt: test suite report:
| target              | platform_name | test suite | result | elapsed_time (sec) | copy_method |
|---------------------|---------------|------------|--------|--------------------|-------------|
| GCC_ARM-NRF52840_DK | NRF52840_DK   | wifi       | OK     | 64.3               | default     |
mbedgt: test suite results: 1 OK
mbedgt: test case report:
| target              | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
|---------------------|---------------|------------|-----------|--------|--------|--------|--------------------|
| GCC_ARM-NRF52840_DK | NRF52840_DK   | wifi       | wifi      | 1      | 0      | OK     | 64.3               |
mbedgt: test case results: 1 OK
mbedgt: completed in 66.81 sec
apps : ['wifi'] memmap ; ['.../mbed-os-benchmarks/BUILD/static/NRF52840_DK/GCC_ARM/wifi/wifi_map.json']

VeijoPesonen · 2019-02-06T15:02:32Z

Ended up being a bit more changes than I anticipated. @SeppoTakalo , @michalpasztamobica please re-review.

0xc0170 · 2019-02-13T13:38:55Z

Any update @VeijoPesonen ?

VeijoPesonen · 2019-02-13T13:43:39Z

@0xc0170 depends from ARMmbed/mbed-os-benchmarks#24

cmonr · 2019-02-13T19:31:03Z

@VeijoPesonen ARMmbed/mbed-os-benchmarks#24 was just merged. It should now be in use within CI.

cmonr · 2019-02-13T19:31:40Z

CI job restarted: jenkins-ci/dynamic-memory-usage

Makes possible to recover from spurious resets addiotionally to planned ones.

0xc0170 · 2019-02-15T10:09:25Z

components/wifi/esp8266-driver/ESP8266Interface.h

@VeijoPesonen Please rebase and we start CI

VeijoPesonen · 2019-02-15T10:26:33Z

@0xc0170 rebase done.

0xc0170 · 2019-02-15T10:34:05Z

CI started

VeijoPesonen · 2019-02-15T11:40:35Z

Something different this time:
The command "W: Failed to fetch http://repo.mongodb.org/apt/ubuntu/dists/trusty/mongodb-org/3.4/Release.gpg The following signatures were invalid: KEYEXPIRED 1515625755" failed 3 times.

0xc0170 · 2019-02-15T12:30:32Z

Travis restarted

mbed-ci · 2019-02-15T13:27:36Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 4
Build artifacts

cmonr · 2019-02-15T18:26:26Z

This appears to be sitting on top of some 5.12 changes.
Release label updated.

michalpasztamobica suggested changes Jan 23, 2019

View reviewed changes

components/wifi/esp8266-driver/ESP8266/ESP8266.cpp Outdated Show resolved Hide resolved

ciarmcom requested review from kjbracey, michalpasztamobica, SeppoTakalo and a team January 23, 2019 16:00

ciarmcom added the needs: review label Jan 23, 2019

SeppoTakalo approved these changes Jan 24, 2019

View reviewed changes

VeijoPesonen mentioned this pull request Jan 25, 2019

ESP8266: OOB handling done based on arrival of SIGIOs #9503

Merged

michalpasztamobica approved these changes Jan 25, 2019

View reviewed changes

cmonr added the release-version: 5.11.4 label Jan 29, 2019

cmonr approved these changes Jan 29, 2019

View reviewed changes

cmonr added needs: CI and removed needs: review labels Jan 29, 2019

cmonr added needs: work and removed needs: CI labels Feb 1, 2019

NirSonnenschein added release-version: 5.11.5 and removed release-version: 5.11.4 labels Feb 7, 2019

cmonr added needs: preceding PR and removed needs: preceding PR labels Feb 13, 2019

Veijo Pesonen added 6 commits February 14, 2019 10:41

ESP8266: handles reset ready as OOB

876a397

Makes possible to recover from spurious resets addiotionally to planned ones.

ESP8266: fixes network status refresh procedure

71e5321

ESP8266: fixes UART HW flow control enabling sequence

108ec44

ESP8266: protects setting UART HW flow control with a mutex

706dd39

ESP8266: prevents doing reset twice in a row, unnecessary

2d6b63d

ESP8266: retry reset attempt once in failure

cbbe2ff

0xc0170 added needs: CI and removed needs: work labels Feb 15, 2019

0xc0170 added ready for merge and removed needs: CI labels Feb 15, 2019

cmonr added release-version: 5.12.0-rc1 and removed release-version: 5.11.5 labels Feb 15, 2019

cmonr merged commit 7dbe541 into ARMmbed:master Feb 15, 2019

cmonr removed the ready for merge label Feb 15, 2019

VeijoPesonen deleted the feature-esp8266_reset_handling branch February 18, 2019 08:31

ESP8266: treats reset-ready-message as OOB #9473

ESP8266: treats reset-ready-message as OOB #9473

Uh oh!

Conversation

VeijoPesonen commented Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Uh oh!

Uh oh!

ciarmcom commented Jan 23, 2019

Uh oh!

cmonr commented Jan 29, 2019

Uh oh!

mbed-ci commented Jan 30, 2019

Test run: FAILED

Uh oh!

cmonr commented Jan 30, 2019

Uh oh!

VeijoPesonen commented Jan 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Jan 31, 2019

Uh oh!

mbed-ci commented Jan 31, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jan 31, 2019

Uh oh!

VeijoPesonen commented Jan 31, 2019

Uh oh!

cmonr commented Jan 31, 2019

Uh oh!

0xc0170 commented Feb 1, 2019

Uh oh!

VeijoPesonen commented Feb 1, 2019

Uh oh!

VeijoPesonen commented Feb 4, 2019

Uh oh!

VeijoPesonen commented Feb 6, 2019

Uh oh!

0xc0170 commented Feb 13, 2019

Uh oh!

VeijoPesonen commented Feb 13, 2019

Uh oh!

cmonr commented Feb 13, 2019

Uh oh!

cmonr commented Feb 13, 2019

Uh oh!

0xc0170 commented Feb 15, 2019

Uh oh!

VeijoPesonen commented Feb 15, 2019

Uh oh!

0xc0170 commented Feb 15, 2019

Uh oh!

VeijoPesonen commented Feb 15, 2019

Uh oh!

0xc0170 commented Feb 15, 2019

Uh oh!

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Uh oh!

cmonr commented Feb 15, 2019

Uh oh!

Uh oh!

VeijoPesonen commented Jan 23, 2019 •

edited

Loading

VeijoPesonen commented Jan 30, 2019 •

edited

Loading