Skip to content

Put LittleFS emulated BD module under .mbedignore #9440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

davidsaada
Copy link
Contributor

Description

Put LittleFS emulated BD module under .mbedignore. The emulated BD is required for simulation of a block device outside mbed-os, but not required in mbed-os.

Resolves #9281.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@geky

@ciarmcom
Copy link
Member

@davidsaada, thank you for your changes.
@geky @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from geky and a team January 20, 2019 16:00
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

test restarted (CI failure)

@mbed-ci
Copy link

mbed-ci commented Jan 21, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2019

Jobs were restarted , all green

@geky
Copy link
Contributor

geky commented Jan 24, 2019

Sorry, I just saw this PR. This one is strange because emubd should be covered by this mbedignore file?
https://github.com/ARMmbed/mbed-os/blob/master/features/storage/filesystem/littlefs/.mbedignore

I'm glad it's fixed but do we know why it wasn't being picked up?

@davidsaada
Copy link
Contributor Author

Sorry, I just saw this PR. This one is strange because emubd should be covered by this mbedignore file?
https://github.com/ARMmbed/mbed-os/blob/master/features/storage/filesystem/littlefs/.mbedignore

I'm glad it's fixed but do we know why it wasn't being picked up?

Oh, I missed that. Should have thought of it, as I've never seen such a problem. Can revert the change and investigate it a bit more with the reporter.

@geky
Copy link
Contributor

geky commented Jan 24, 2019

Don't worry about reverting (sorry if I'm getting this too you too late). I'm about to clobber the change with a minor release of littlefs (1.7).

@davidsaada davidsaada deleted the david_lfs_emubd_ignore branch February 22, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants