Skip to content

tools: adds and implements a --custom-targets command line switch #9401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2019

Conversation

0Grit
Copy link

@0Grit 0Grit commented Jan 16, 2019

Description

Per #6581

adds and implements a --custom-targets command line switch

If --custom-targets switch is provided, it will be used for custom_targets.json directory instead of the --source switch.

Was looking for a test of tools/options.py's extract_mcu's to update but didn't find.
Point me in the right direction if I missed it.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

@0Grit 0Grit changed the title Adds adds and implements a --custom-targets command line switch tools: adds and implements a --custom-targets command line switch Jan 16, 2019
@ciarmcom ciarmcom requested review from theotherjimmy and a team January 16, 2019 18:00
@ciarmcom
Copy link
Member

@loverdeg-ep, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the addition of --custom-targets into get_default_options_parser? Then you can remove it from get_config.py, make.py and test.py.

@theotherjimmy
Copy link
Contributor

Was looking for a test of tools/options.py's extract_mcu's to update but didn't find.

I don't think we have a test for that. I'll accept any tests, and I can merge it with other tests if needed or if I find other tests later.

@0Grit
Copy link
Author

0Grit commented Jan 16, 2019

Could you move the addition of --custom-targets into get_default_options_parser? Then you can remove it from get_config.py, make.py and test.py.

Was hoping you'd say that!

@0Grit 0Grit force-pushed the custom-targets-option branch from 8fe2326 to 97f20f5 Compare January 17, 2019 12:54
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more duplicated addition of --custom-targets

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously clicked the wrong radial button. Meant to request changes.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

Can you also rebase, once you add commits to address review, thanks (will fix spellcheck failure)

@0Grit 0Grit force-pushed the custom-targets-option branch from 97f20f5 to bb5ea80 Compare January 17, 2019 18:16
@0Grit
Copy link
Author

0Grit commented Jan 18, 2019

@theotherjimmy did I miss anything? any last requests?

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loverdeg-ep You missed nothing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 091fe2b into ARMmbed:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants