-
Notifications
You must be signed in to change notification settings - Fork 3k
tools: adds and implements a --custom-targets command line switch #9401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@loverdeg-ep, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the addition of --custom-targets
into get_default_options_parser
? Then you can remove it from get_config.py
, make.py
and test.py
.
I don't think we have a test for that. I'll accept any tests, and I can merge it with other tests if needed or if I find other tests later. |
Was hoping you'd say that! |
8fe2326
to
97f20f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more duplicated addition of --custom-targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously clicked the wrong radial button. Meant to request changes.
Can you also rebase, once you add commits to address review, thanks (will fix spellcheck failure) |
97f20f5
to
bb5ea80
Compare
@theotherjimmy did I miss anything? any last requests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loverdeg-ep You missed nothing.
Ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Per #6581
If
--custom-targets
switch is provided, it will be used for custom_targets.json directory instead of the--source
switch.Was looking for a test of
tools/options.py
's extract_mcu's to update but didn't find.Point me in the right direction if I missed it.
Pull request type
Reviewers
@theotherjimmy