Skip to content

COMPONENT_SD tests update for small RAM targets #9236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

COMPONENT_SD tests update for small RAM targets #9236

merged 1 commit into from
Jan 30, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

DIRS and SEEK tests are FAIL for targets with small RAM.

Buffer size can now be specified for each target.
Default size is not changed with that patch.

It has been divided by 2 for some small RAM targets.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom
Copy link
Member

ciarmcom commented Jan 3, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team January 3, 2019 14:00
cmonr
cmonr approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromecoutant
Copy link
Collaborator Author

Any update ? :-)

@dannybenor
Copy link

@theamirocohen can you review?

@jeromecoutant
DIRS and SEEK SD tests update for small RAM targets
f3ba34a 
Test buffer size can now be specified for each target
@jeromecoutant
Copy link
Collaborator Author

@theamirocohen any update ?

Thx

@cmonr cmonr requested a review from theamirocohen January 18, 2019 17:30
theamirocohen
theamirocohen reviewed Jan 20, 2019
View reviewed changes
components/storage/blockdevice/COMPONENT_SD/config/mbed_lib.json
@@ -9,20 +9,30 @@
"CMD_TIMEOUT": 10000,
"CMD0_IDLE_STATE_RETRIES": 5,
"INIT_FREQUENCY": 100000,
"CRC_ENABLED": 1
"CRC_ENABLED": 1,
"TEST_BUFFER": 8192
},
"target_overrides": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Why were these 4 boards removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Why were these 4 boards removed?

@jeromecoutant

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??
There is no removed boards...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I saw 4 boards that were removed, never mind.
Thanks

@dannybenor
Copy link

@jeromecoutant without the addition of "components_add": ["SD"] in targets.json I think the tests will not be relevant

@jeromecoutant
Copy link
Collaborator Author

without the addition of "components_add": ["SD"] in targets.json I think the tests will not be relevant

Sure... But this patch is when we add this SD component...
Thx

@jeromecoutant
Copy link
Collaborator Author

@theamirocohen any update ?
Thx

@theamirocohen
Copy link
Contributor

LGTM

@jeromecoutant
Copy link
Collaborator Author

Could we start CI ?
Thx

@adbridge
Copy link
Contributor

ci started

@mbed-ci
Copy link

mbed-ci commented Jan 29, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

Marking for patch, but would like another @ARMmbed/mbed-os-maintainers to ack.

@0xc0170 0xc0170 merged commit 1031e2d into ARMmbed:master Jan 30, 2019
@jeromecoutant jeromecoutant deleted the PR_SD_TEST branch January 30, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theamirocohen theamirocohen theamirocohen approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jeromecoutant @ciarmcom @dannybenor @theamirocohen @adbridge @mbed-ci @cmonr @0xc0170