Cellular: fix state machine to check network attach #9152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check to state machine that if modem is attached to a network it is considered to be registered to a network and state machine can continue to next states. This fixed issues seen in IoT network that network does not allow registering if already attached.
|
@jarvte, thank you for your changes. |
0xc0170
approved these changes
Jan 2, 2019
|
@ARMmbed/mbed-os-wan Please review |
AnttiKauppila
approved these changes
Jan 3, 2019
|
@jarvte The CellularStateMachine is not used directly as a user-facing API, correct? Noticed that the constructor was updated, but as along as the answer to the above question is true, this can come into a patch release. |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Waiting on confirmation of this befure merging. Also @AriParkkila @mirelachirica, in case y'all want to still review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added check to state machine that if modem is attached to a network it is considered to be registered to a network and state machine can continue to next states. This fixes issues seen in IoT network
that network does not allow registering if already attached.
@AriParkkila @mirelachirica please review.
Pull request type