Add some rounding to determine the pulse value for PWM for the STM target #9105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LaurentLouf, thank you for your changes. |
LMESTM
approved these changes
Dec 14, 2018
|
@LaurentLouf Thanks for the contribution, this is now approved and will be moved to CI stage CI started |
0xc0170
approved these changes
Dec 14, 2018
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Failure not related, and seeing it the first time (will track this one) Restarting |
|
Test restarted |
|
Restarted entire pipeline |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes are pretty obvious : when computing the pulse value for PWM in the function pwmout_write, no rounding was performed, so for very small periods (think <10µs), it could cause quite a large offset for changes in pulse values. This pull request solves that by adding one of the most common way to round a value after float to int casting.
Pull request type
Fix for a particular set of targets, haven't checked if this omission is also present on other targets.