Skip to content

Fix a few bugs in TDBStore and KV config #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

davidsaada
Copy link
Contributor

Description

This PR fixes a few bugs in TDBStore and KV config.

  1. Don't initialize TDBStore if already initialized.
  2. When reading a TDBStore record, make sure size calculation don't wrap around (can happen in a corrupt record).
  3. Fix a few problems in KV config init and deinit logic.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom
Copy link
Member

ciarmcom commented Dec 6, 2018

@davidsaada, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team December 6, 2018 12:00
@adbridge
Copy link
Contributor

adbridge commented Dec 7, 2018

@davidsaada is this for RC3 ?

@adbridge
Copy link
Contributor

adbridge commented Dec 7, 2018

@dannybenor can someone review this please

@davidsaada
Copy link
Contributor Author

is this for RC3 ?

@adbridge I think it better be. No show stoppers fixed here, but the missing init check (which may cause double init calls) isn't very nice.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 10, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit eec536b into ARMmbed:master Dec 10, 2018
@davidsaada davidsaada deleted the david_tdbstore_fixes branch December 12, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants