Skip to content

TARGET_WICED updated. #8949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

KariHaapalehto
Copy link
Contributor

Description

Connection status issue corrected.
If the link layer status changes, the connection status callback is now called correctly.

Changes have been tested locally and at CI.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

Travis failure will be fixed on master soon (we will request rebase once done). See #8945

0xc0170
0xc0170 previously requested changes Dec 3, 2018
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too fast to approve. Can you add details to the commit message (what is being updated - what this commit brings? ). The description from here would be a good start

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

Travis failure will be fixed on master soon (we will request rebase once done). See #8945

The fix is on master, if you rebase, it should allow travis to run

Connection status issue corrected. If the link layer status changes,
the connection status callback is now called correctly.

mbedtls headers from library are removed and the mbed-os one's are used.
@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@cmonr
Copy link
Contributor

cmonr commented Dec 4, 2018

Just wanted to say, thank you for the details in the commit!

@cmonr cmonr merged commit e30194f into ARMmbed:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants